Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add version number to masthead #1723

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

zeroedin
Copy link
Collaborator

@zeroedin zeroedin commented Jul 23, 2024

What I did

  1. Added version number to masthead from pkg.version in the 11ty data and linked the version to our release tags.

Closes #1485

TODO

  • Decide if we want to roll out branch builds of previous releases on Netlify.
    Note: If we go that route we could create a yaml file that contains data binding versions to release Netlify deploy URLs. ie. Currently, we have staging/charmander as a branch deployment this translates into a URL of https://staging-charmander--red-hat-design-system.netlify.app/. We could create branches such as version/1.4.4 which would translate to: https://version-1-4-4--red-hat-design-system.netlify.app/ or similar then we could create a dropdown selection from this data instead of the current link in this PR. I was hoping I could add tag/v.1.4.4 to the branch deploys but was unsure how to trigger a build retroactively. Addition thoughts are welcome.

Testing Instructions

  1. View Deploy Preview

Notes to Reviewers

@zeroedin zeroedin added the docs Improvements or additions to documentation label Jul 23, 2024
@zeroedin zeroedin self-assigned this Jul 23, 2024
Copy link

changeset-bot bot commented Jul 23, 2024

⚠️ No Changeset found

Latest commit: e226a8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit e226a8c
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/66a01c84024dd500083e667a
😎 Deploy Preview https://deploy-preview-1723--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jul 23, 2024

Size Change: 0 B

Total Size: 250 kB

ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/context.js 162 B
./elements/rh-accordion/rh-accordion-header.js 3.74 kB
./elements/rh-accordion/rh-accordion-panel.js 1.47 kB
./elements/rh-accordion/rh-accordion.js 3.7 kB
./elements/rh-alert/rh-alert.js 4.49 kB
./elements/rh-audio-player/rh-audio-player-about.js 1.68 kB
./elements/rh-audio-player/rh-audio-player-button.css.js 437 B
./elements/rh-audio-player/rh-audio-player-panel.css.js 554 B
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 1.51 kB
./elements/rh-audio-player/rh-audio-player-subscribe.js 1.01 kB
./elements/rh-audio-player/rh-audio-player.js 14.4 kB
./elements/rh-audio-player/rh-cue.js 2.01 kB
./elements/rh-audio-player/rh-transcript.js 2.29 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 2.93 kB
./elements/rh-back-to-top/rh-back-to-top.js 2.1 kB
./elements/rh-badge/rh-badge.js 1.04 kB
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-button/rh-button.js 4.45 kB
./elements/rh-card/rh-card.js 1.96 kB
./elements/rh-code-block/rh-code-block.js 5.62 kB
./elements/rh-cta/rh-cta.js 4.59 kB
./elements/rh-dialog/rh-dialog.js 4.79 kB
./elements/rh-dialog/yt-api.js 617 B
./elements/rh-footer/rh-footer-block.js 770 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.17 kB
./elements/rh-footer/rh-footer-social-link.js 1.35 kB
./elements/rh-footer/rh-footer-universal.js 2.05 kB
./elements/rh-footer/rh-footer.css.js 2.16 kB
./elements/rh-footer/rh-footer.js 3.04 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-menu/rh-menu.js 1.18 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.58 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.46 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.9 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 5.55 kB
./elements/rh-navigation-secondary/test/fixtures.js 846 B
./elements/rh-pagination/rh-pagination.js 4.47 kB
./elements/rh-site-status/rh-site-status.js 3.18 kB
./elements/rh-skip-link/rh-skip-link.js 1.13 kB
./elements/rh-spinner/rh-spinner.js 1.61 kB
./elements/rh-stat/rh-stat.js 2.24 kB
./elements/rh-subnav/rh-subnav.js 2.83 kB
./elements/rh-surface/rh-surface.js 868 B
./elements/rh-table/rh-sort-button.js 1.49 kB
./elements/rh-table/rh-table.js 3.02 kB
./elements/rh-tabs/context.js 160 B
./elements/rh-tabs/rh-tab-panel.js 1.15 kB
./elements/rh-tabs/rh-tab.js 2.92 kB
./elements/rh-tabs/rh-tabs.js 4.05 kB
./elements/rh-tag/rh-tag.js 2.06 kB
./elements/rh-tile/rh-tile-group.js 1.76 kB
./elements/rh-tile/rh-tile.js 4.85 kB
./elements/rh-timestamp/rh-timestamp.js 983 B
./elements/rh-tooltip/rh-tooltip.js 2.24 kB
./lib/context/color/consumer.js 1.16 kB
./lib/context/color/context-color.css.js 268 B
./lib/context/color/controller.js 885 B
./lib/context/color/provider.js 2.04 kB
./lib/context/event.js 583 B
./lib/context/headings/consumer.js 722 B
./lib/context/headings/controller.js 1.12 kB
./lib/context/headings/provider.js 1.24 kB
./lib/DirController.js 565 B
./lib/elements/rh-context-demo/rh-context-demo.js 1.15 kB
./lib/elements/rh-context-picker/rh-context-picker.js 2.23 kB
./lib/functions.js 175 B
./lib/I18nController.js 1.38 kB
./lib/ScreenSizeController.js 849 B
./react/rh-accordion/rh-accordion-header.js 215 B
./react/rh-accordion/rh-accordion-panel.js 185 B
./react/rh-accordion/rh-accordion.js 215 B
./react/rh-alert/rh-alert.js 184 B
./react/rh-audio-player/rh-audio-player-about.js 191 B
./react/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 214 B
./react/rh-audio-player/rh-audio-player-subscribe.js 196 B
./react/rh-audio-player/rh-audio-player.js 183 B
./react/rh-audio-player/rh-cue.js 195 B
./react/rh-audio-player/rh-transcript.js 207 B
./react/rh-avatar/rh-avatar.js 173 B
./react/rh-back-to-top/rh-back-to-top.js 183 B
./react/rh-badge/rh-badge.js 174 B
./react/rh-blockquote/rh-blockquote.js 179 B
./react/rh-button/rh-button.js 174 B
./react/rh-card/rh-card.js 172 B
./react/rh-code-block/rh-code-block.js 181 B
./react/rh-cta/rh-cta.js 170 B
./react/rh-dialog/rh-dialog.js 203 B
./react/rh-footer/rh-footer-block.js 184 B
./react/rh-footer/rh-footer-copyright.js 187 B
./react/rh-footer/rh-footer-links.js 185 B
./react/rh-footer/rh-footer-social-link.js 193 B
./react/rh-footer/rh-footer-universal.js 188 B
./react/rh-footer/rh-footer.js 174 B
./react/rh-footer/rh-global-footer.js 185 B
./react/rh-menu/rh-menu.js 173 B
./react/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 217 B
./react/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 205 B
./react/rh-navigation-secondary/rh-navigation-secondary-menu.js 199 B
./react/rh-navigation-secondary/rh-navigation-secondary-overlay.js 201 B
./react/rh-navigation-secondary/rh-navigation-secondary.js 213 B
./react/rh-pagination/rh-pagination.js 178 B
./react/rh-site-status/rh-site-status.js 181 B
./react/rh-skip-link/rh-skip-link.js 181 B
./react/rh-spinner/rh-spinner.js 175 B
./react/rh-stat/rh-stat.js 171 B
./react/rh-subnav/rh-subnav.js 175 B
./react/rh-surface/rh-surface.js 175 B
./react/rh-table/rh-sort-button.js 213 B
./react/rh-table/rh-table.js 174 B
./react/rh-tabs/rh-tab-panel.js 181 B
./react/rh-tabs/rh-tab.js 187 B
./react/rh-tabs/rh-tabs.js 174 B
./react/rh-tag/rh-tag.js 182 B
./react/rh-tile/rh-tile-group.js 183 B
./react/rh-tile/rh-tile.js 194 B
./react/rh-timestamp/rh-timestamp.js 176 B
./react/rh-tooltip/rh-tooltip.js 175 B
./rhds.min.js 90.5 kB

compressed-size-action

@zeroedin zeroedin requested a review from bennypowers July 23, 2024 18:06
@bennypowers
Copy link
Member

We definitely want to do the versioned deploys, and this PR is also good enough on is own

@zeroedin zeroedin enabled auto-merge (squash) July 23, 2024 19:57
Copy link
Collaborator

@markcaron markcaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limber Gymnasts Tumble Masterfully

image

@zeroedin zeroedin merged commit cf0ec84 into main Jul 24, 2024
10 checks passed
@zeroedin zeroedin deleted the docs/rhds-version-number branch July 24, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
Status: Done ☑️
Development

Successfully merging this pull request may close these issues.

[docs] Add RHDS version number to docs masthead
3 participants