-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add version number to masthead #1723
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: 0 B Total Size: 250 kB ℹ️ View Unchanged
|
We definitely want to do the versioned deploys, and this PR is also good enough on is own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I did
pkg.version
in the 11ty data and linked the version to our release tags.Closes #1485
TODO
Note: If we go that route we could create a yaml file that contains data binding versions to release Netlify deploy URLs. ie. Currently, we have
staging/charmander
as a branch deployment this translates into a URL ofhttps://staging-charmander--red-hat-design-system.netlify.app/
. We could create branches such asversion/1.4.4
which would translate to:https://version-1-4-4--red-hat-design-system.netlify.app/
or similar then we could create a dropdown selection from this data instead of the current link in this PR. I was hoping I could addtag/v.1.4.4
to the branch deploys but was unsure how to trigger a build retroactively. Addition thoughts are welcome.Testing Instructions
Notes to Reviewers