Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tag): font inheritance #1574

Merged
merged 3 commits into from
May 21, 2024
Merged

fix(tag): font inheritance #1574

merged 3 commits into from
May 21, 2024

Conversation

zeroedin
Copy link
Collaborator

@zeroedin zeroedin commented May 21, 2024

What I did

  1. Add font-family to styles

Closes #1331

Testing Instructions

  1. View demo and doc pages

Notes to Reviewers

confirm page font-style doesn't leak

@zeroedin zeroedin added the bug Something isn't working label May 21, 2024
@zeroedin zeroedin self-assigned this May 21, 2024
Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 7577957

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 21, 2024

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 7577957
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/664caf667b128600081d88ad
😎 Deploy Preview https://deploy-preview-1574--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bennypowers bennypowers changed the title Fix/tag/font inheritance fix(tag): font inheritance May 21, 2024
Copy link
Contributor

github-actions bot commented May 21, 2024

Size Change: +105 B (+0.04%)

Total Size: 250 kB

Filename Size Change
./elements/rh-tag/rh-tag.js 2.06 kB +101 B (+5.17%) 🔍
./rhds.min.js 89.9 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/context.js 163 B
./elements/rh-accordion/rh-accordion-header.js 3.75 kB
./elements/rh-accordion/rh-accordion-panel.js 1.47 kB
./elements/rh-accordion/rh-accordion.js 3.71 kB
./elements/rh-alert/rh-alert.js 4.45 kB
./elements/rh-audio-player/rh-audio-player-about.js 1.67 kB
./elements/rh-audio-player/rh-audio-player-button.css.js 434 B
./elements/rh-audio-player/rh-audio-player-panel.css.js 551 B
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 1.51 kB
./elements/rh-audio-player/rh-audio-player-subscribe.js 1.01 kB
./elements/rh-audio-player/rh-audio-player.js 14.3 kB
./elements/rh-audio-player/rh-cue.js 2.01 kB
./elements/rh-audio-player/rh-transcript.js 2.28 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 2.91 kB
./elements/rh-back-to-top/rh-back-to-top.js 2.1 kB
./elements/rh-badge/rh-badge.js 1.04 kB
./elements/rh-blockquote/rh-blockquote.js 1.94 kB
./elements/rh-button/rh-button.js 4.45 kB
./elements/rh-card/rh-card.js 1.96 kB
./elements/rh-code-block/rh-code-block.js 5.28 kB
./elements/rh-cta/rh-cta.js 4.57 kB
./elements/rh-dialog/rh-dialog.js 4.79 kB
./elements/rh-dialog/yt-api.js 617 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.18 kB
./elements/rh-footer/rh-footer-social-link.js 1.35 kB
./elements/rh-footer/rh-footer-universal.js 2.04 kB
./elements/rh-footer/rh-footer.css.js 2.15 kB
./elements/rh-footer/rh-footer.js 3.06 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-menu/rh-menu.js 1.19 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.59 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.46 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.9 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 572 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 5.37 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.46 kB
./elements/rh-site-status/rh-site-status.js 3.18 kB
./elements/rh-skip-link/rh-skip-link.js 1.14 kB
./elements/rh-spinner/rh-spinner.js 1.61 kB
./elements/rh-stat/rh-stat.js 2.25 kB
./elements/rh-subnav/rh-subnav.js 2.83 kB
./elements/rh-surface/rh-surface.js 862 B
./elements/rh-table/rh-sort-button.js 1.48 kB
./elements/rh-table/rh-table.js 3.03 kB
./elements/rh-tabs/context.js 159 B
./elements/rh-tabs/rh-tab-panel.js 1.15 kB
./elements/rh-tabs/rh-tab.js 3.08 kB
./elements/rh-tabs/rh-tabs.js 3.91 kB
./elements/rh-tile/rh-tile-group.js 1.76 kB
./elements/rh-tile/rh-tile.js 4.82 kB
./elements/rh-timestamp/rh-timestamp.js 985 B
./elements/rh-tooltip/rh-tooltip.js 2.25 kB
./lib/context/color/consumer.js 1.16 kB
./lib/context/color/context-color.css.js 267 B
./lib/context/color/controller.js 892 B
./lib/context/color/provider.js 2.06 kB
./lib/context/event.js 587 B
./lib/context/headings/consumer.js 724 B
./lib/context/headings/controller.js 1.13 kB
./lib/context/headings/provider.js 1.24 kB
./lib/DirController.js 568 B
./lib/elements/rh-context-demo/rh-context-demo.js 1.16 kB
./lib/elements/rh-context-picker/rh-context-picker.js 2.43 kB
./lib/functions.js 175 B
./lib/I18nController.js 1.38 kB
./lib/ScreenSizeController.js 856 B
./react/elements/rh-accordion/rh-accordion-header.js 215 B
./react/elements/rh-accordion/rh-accordion-panel.js 188 B
./react/elements/rh-accordion/rh-accordion.js 216 B
./react/elements/rh-alert/rh-alert.js 188 B
./react/elements/rh-audio-player/rh-audio-player-about.js 193 B
./react/elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 215 B
./react/elements/rh-audio-player/rh-audio-player-subscribe.js 197 B
./react/elements/rh-audio-player/rh-audio-player.js 185 B
./react/elements/rh-audio-player/rh-cue.js 196 B
./react/elements/rh-audio-player/rh-transcript.js 207 B
./react/elements/rh-avatar/rh-avatar.js 177 B
./react/elements/rh-back-to-top/rh-back-to-top.js 186 B
./react/elements/rh-badge/rh-badge.js 177 B
./react/elements/rh-blockquote/rh-blockquote.js 181 B
./react/elements/rh-button/rh-button.js 177 B
./react/elements/rh-card/rh-card.js 176 B
./react/elements/rh-code-block/rh-code-block.js 183 B
./react/elements/rh-cta/rh-cta.js 174 B
./react/elements/rh-dialog/rh-dialog.js 206 B
./react/elements/rh-footer/rh-footer-block.js 187 B
./react/elements/rh-footer/rh-footer-copyright.js 189 B
./react/elements/rh-footer/rh-footer-links.js 187 B
./react/elements/rh-footer/rh-footer-social-link.js 194 B
./react/elements/rh-footer/rh-footer-universal.js 190 B
./react/elements/rh-footer/rh-footer.js 178 B
./react/elements/rh-footer/rh-global-footer.js 188 B
./react/elements/rh-menu/rh-menu.js 176 B
./react/elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 243 B
./react/elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 233 B
./react/elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 225 B
./react/elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 202 B
./react/elements/rh-navigation-secondary/rh-navigation-secondary.js 239 B
./react/elements/rh-pagination/rh-pagination.js 181 B
./react/elements/rh-site-status/rh-site-status.js 182 B
./react/elements/rh-skip-link/rh-skip-link.js 184 B
./react/elements/rh-spinner/rh-spinner.js 177 B
./react/elements/rh-stat/rh-stat.js 176 B
./react/elements/rh-subnav/rh-subnav.js 178 B
./react/elements/rh-surface/rh-surface.js 178 B
./react/elements/rh-table/rh-sort-button.js 213 B
./react/elements/rh-table/rh-table.js 177 B
./react/elements/rh-tabs/rh-tab-panel.js 181 B
./react/elements/rh-tabs/rh-tab.js 188 B
./react/elements/rh-tabs/rh-tabs.js 176 B
./react/elements/rh-tag/rh-tag.js 183 B
./react/elements/rh-tile/rh-tile-group.js 185 B
./react/elements/rh-tile/rh-tile.js 197 B
./react/elements/rh-timestamp/rh-timestamp.js 179 B
./react/elements/rh-tooltip/rh-tooltip.js 177 B

compressed-size-action

@bennypowers bennypowers merged commit 8365fac into main May 21, 2024
8 checks passed
@bennypowers bennypowers deleted the fix/tag/font-inheritance branch May 21, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done ☑️
Development

Successfully merging this pull request may close these issues.

[bug] <rh-tag> inherits font styles that it shouldn't
3 participants