Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tile): add hover animation on arrow in footer #1283

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

eyevana
Copy link
Collaborator

@eyevana eyevana commented Oct 19, 2023

What I did

  1. Copied the same arrow animation from rh-cta, activated on hover.

Testing Instructions

  1. Take a look at the deployment preview and verify the animation appears on hover, and that it doesn't impact the size of the tile element.

Notes to Reviewers

Closes #1270

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: cf2b491

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit cf2b491
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/6539645f7b3c590007cccd70
😎 Deploy Preview https://deploy-preview-1283--red-hat-design-system.netlify.app/elements/tile/code
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eyevana eyevana requested review from nikkimk and marionnegp October 19, 2023 15:30
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Size Change: +197 B (0%)

Total Size: 207 kB

Filename Size Change
./elements/rh-tile/rh-tile.js 4.2 kB +115 B (+3%)
./rhds.min.js 81.7 kB +82 B (0%)
ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 1.98 kB
./elements/rh-accordion/rh-accordion-panel.js 1.24 kB
./elements/rh-accordion/rh-accordion.js 1.17 kB
./elements/rh-alert/rh-alert.js 4.24 kB
./elements/rh-audio-player/rh-audio-player-about.js 1.85 kB
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 1.51 kB
./elements/rh-audio-player/rh-audio-player-subscribe.js 1.43 kB
./elements/rh-audio-player/rh-audio-player.js 14.2 kB
./elements/rh-audio-player/rh-cue.js 2 kB
./elements/rh-audio-player/rh-transcript.js 2.94 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 2.9 kB
./elements/rh-badge/rh-badge.js 1.01 kB
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-button/rh-button.js 4.39 kB
./elements/rh-card/rh-card.js 1.88 kB
./elements/rh-code-block/rh-code-block.js 1.19 kB
./elements/rh-context-provider/rh-context-provider.js 185 B
./elements/rh-cta/rh-cta.js 4.58 kB
./elements/rh-dialog/rh-dialog.js 1.6 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.18 kB
./elements/rh-footer/rh-footer-social-link.js 960 B
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.07 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-menu/rh-menu.js 1.02 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.55 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.46 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.9 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 5.45 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.45 kB
./elements/rh-spinner/rh-spinner.js 1.61 kB
./elements/rh-stat/rh-stat.js 2.24 kB
./elements/rh-subnav/rh-subnav.js 2.84 kB
./elements/rh-table/rh-sort-button.js 1.31 kB
./elements/rh-table/rh-table.js 2.29 kB
./elements/rh-tabs/rh-tab-panel.js 789 B
./elements/rh-tabs/rh-tab.js 1.81 kB
./elements/rh-tabs/rh-tabs.js 1.86 kB
./elements/rh-tag/rh-tag.js 1.96 kB
./elements/rh-tile/rh-tile-group.js 1.76 kB
./elements/rh-timestamp/rh-timestamp.js 974 B
./elements/rh-tooltip/rh-tooltip.js 2.15 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 1.99 kB
./lib/context/event.js 598 B
./lib/context/headings/consumer.js 711 B
./lib/context/headings/controller.js 1.14 kB
./lib/context/headings/provider.js 1.23 kB
./lib/DirController.js 569 B
./lib/elements/rh-context-picker/rh-context-picker.js 1.16 kB
./lib/elements/rh-context-provider/rh-context-provider.js 746 B
./lib/functions.js 175 B
./lib/I18nController.js 1.38 kB
./lib/ScreenSizeController.js 856 B

compressed-size-action

Copy link
Collaborator

@marionnegp marionnegp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's Go To Miami.

@bennypowers bennypowers changed the title fix(rh-tile): add hover animation on arrow in footer fix(tile): add hover animation on arrow in footer Oct 21, 2023
@bennypowers bennypowers enabled auto-merge (squash) October 21, 2023 17:36
@bennypowers bennypowers merged commit b3f7b18 into main Oct 25, 2023
6 checks passed
@bennypowers bennypowers deleted the fix/rh-tile/arrow-hover-effect branch October 25, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ☑️
Development

Successfully merging this pull request may close these issues.

[feat] Animate <rh-tile>'s arrow icon on hover
4 participants