Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: playgrounds performance improvements #1254

Merged
merged 10 commits into from
Oct 11, 2023

Conversation

bennypowers
Copy link
Member

What I did

  1. improved docs demo playground loading performance by bundling the playground-elements dependency

Testing Instructions

  1. check out a element code page and click "load demo", compare with ux.

Notes to Reviewers

potential security issue with sandbox urls, but we don't have any code on the back end so 🤷

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

⚠️ No Changeset found

Latest commit: 70ed879

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 70ed879
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/6526fb6cdc2707000802c0e4
😎 Deploy Preview https://deploy-preview-1254--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Size Change: 0 B

Total Size: 190 kB

ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 1.98 kB
./elements/rh-accordion/rh-accordion-panel.js 1.24 kB
./elements/rh-accordion/rh-accordion.js 1.17 kB
./elements/rh-alert/rh-alert.js 4.24 kB
./elements/rh-audio-player/rh-audio-player-about.js 1.85 kB
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 1.51 kB
./elements/rh-audio-player/rh-audio-player-subscribe.js 1.43 kB
./elements/rh-audio-player/rh-audio-player.js 14.2 kB
./elements/rh-audio-player/rh-cue.js 2 kB
./elements/rh-audio-player/rh-transcript.js 2.94 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 2.88 kB
./elements/rh-badge/rh-badge.js 862 B
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-button/rh-button.js 3.77 kB
./elements/rh-card/rh-card.js 1.88 kB
./elements/rh-code-block/rh-code-block.js 1.18 kB
./elements/rh-context-provider/rh-context-provider.js 185 B
./elements/rh-cta/rh-cta.js 4.06 kB
./elements/rh-dialog/rh-dialog.js 1.6 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.18 kB
./elements/rh-footer/rh-footer-social-link.js 960 B
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.07 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-menu/rh-menu.js 1.02 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.55 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.46 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.9 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 4.8 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.45 kB
./elements/rh-spinner/rh-spinner.js 1.51 kB
./elements/rh-stat/rh-stat.js 2.24 kB
./elements/rh-subnav/rh-subnav.js 2.84 kB
./elements/rh-tabs/rh-tab-panel.js 789 B
./elements/rh-tabs/rh-tab.js 1.81 kB
./elements/rh-tabs/rh-tabs.js 1.86 kB
./elements/rh-tag/rh-tag.js 1.73 kB
./elements/rh-timestamp/rh-timestamp.js 974 B
./elements/rh-tooltip/rh-tooltip.js 1.07 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 1.99 kB
./lib/context/event.js 598 B
./lib/context/headings/consumer.js 711 B
./lib/context/headings/controller.js 1.14 kB
./lib/context/headings/provider.js 1.23 kB
./lib/DirController.js 569 B
./lib/elements/rh-context-picker/rh-context-picker.js 1.16 kB
./lib/elements/rh-context-provider/rh-context-provider.js 746 B
./lib/functions.js 175 B
./lib/I18nController.js 1.38 kB
./lib/ScreenSizeController.js 856 B
./rhds.min.js 77.6 kB

compressed-size-action

Co-Authored-By: Steven Spriggs <[email protected]>
@bennypowers bennypowers enabled auto-merge (squash) October 9, 2023 13:30
@bennypowers bennypowers force-pushed the docs/playground/perf-improvement-bundle branch from 6e711d2 to d90fe4f Compare October 9, 2023 13:53
@bennypowers bennypowers requested a review from zeroedin October 9, 2023 13:56
Copy link
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be out of scope for this PR, but noticed that code was getting "mixed" in the playground demos as well. Screen shot below shows context-picker somehow getting injected with the demo stylesheet and a head tag.

image

@bennypowers
Copy link
Member Author

Might be out of scope for this PR, but noticed that code was getting "mixed" in the playground demos as well. Screen shot below shows context-picker somehow getting injected with the demo stylesheet and a head tag.

image

try clearing site data including cache and service workers

@zeroedin
Copy link
Collaborator

zeroedin commented Oct 9, 2023

try clearing site data including cache and service workers

no go, happens in all browsers, firefox, safari and chrome.

@brianferry
Copy link
Collaborator

try clearing site data including cache and service workers

no go, happens in all browsers, firefox, safari and chrome.

FWIW it looks like this is the same behavior that exists currently on ux.redhat.com so not an issue with this PR but an issue we'll want to add

@bennypowers
Copy link
Member Author

can yyou open a new issue?

@brianferry
Copy link
Collaborator

Added #1255

@bennypowers bennypowers requested a review from zeroedin October 11, 2023 05:35
Copy link
Collaborator

@zeroedin zeroedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bennypowers bennypowers merged commit 1275572 into main Oct 11, 2023
@bennypowers bennypowers deleted the docs/playground/perf-improvement-bundle branch October 11, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ☑️
Development

Successfully merging this pull request may close these issues.

3 participants