Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navigation-secondary): add roving tabindex controller #1225

Merged
merged 9 commits into from
Oct 16, 2023

Conversation

zeroedin
Copy link
Collaborator

@zeroedin zeroedin commented Sep 18, 2023

What I did

  1. Add roving tabindex controller to navigation-secondary top level nav slotted links.
  • Add changeset

Testing Instructions

  1. View Deploy preview

Notes to Reviewers

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

🦋 Changeset detected

Latest commit: 59729c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rhds/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 59729c4
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/652d3fdb08954c00083767e9
😎 Deploy Preview https://deploy-preview-1225--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeroedin zeroedin self-assigned this Sep 18, 2023
@zeroedin zeroedin added the feature New feature or request label Sep 18, 2023
@zeroedin zeroedin force-pushed the feat/navigation-secondary/rti branch from 0aeeb1a to c198810 Compare September 18, 2023 16:32
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

Size Change: +1.32 kB (+1%)

Total Size: 197 kB

Filename Size Change
./elements/rh-navigation-secondary/rh-navigation-secondary.js 5.45 kB +667 B (+14%) ⚠️
./rhds.min.js 79.8 kB +657 B (+1%)
ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 1.98 kB
./elements/rh-accordion/rh-accordion-panel.js 1.24 kB
./elements/rh-accordion/rh-accordion.js 1.17 kB
./elements/rh-alert/rh-alert.js 4.24 kB
./elements/rh-audio-player/rh-audio-player-about.js 1.85 kB
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 1.51 kB
./elements/rh-audio-player/rh-audio-player-subscribe.js 1.43 kB
./elements/rh-audio-player/rh-audio-player.js 14.2 kB
./elements/rh-audio-player/rh-cue.js 2 kB
./elements/rh-audio-player/rh-transcript.js 2.94 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 2.9 kB
./elements/rh-badge/rh-badge.js 862 B
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-button/rh-button.js 3.77 kB
./elements/rh-card/rh-card.js 1.88 kB
./elements/rh-code-block/rh-code-block.js 1.19 kB
./elements/rh-context-provider/rh-context-provider.js 185 B
./elements/rh-cta/rh-cta.js 4.58 kB
./elements/rh-dialog/rh-dialog.js 1.6 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.18 kB
./elements/rh-footer/rh-footer-social-link.js 960 B
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.07 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-menu/rh-menu.js 1.02 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.55 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.46 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.9 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.45 kB
./elements/rh-spinner/rh-spinner.js 1.51 kB
./elements/rh-stat/rh-stat.js 2.24 kB
./elements/rh-subnav/rh-subnav.js 2.84 kB
./elements/rh-table/rh-sort-button.js 1.31 kB
./elements/rh-table/rh-table.js 2.29 kB
./elements/rh-tabs/rh-tab-panel.js 789 B
./elements/rh-tabs/rh-tab.js 1.81 kB
./elements/rh-tabs/rh-tabs.js 1.86 kB
./elements/rh-tag/rh-tag.js 1.73 kB
./elements/rh-timestamp/rh-timestamp.js 974 B
./elements/rh-tooltip/rh-tooltip.js 1.07 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 1.99 kB
./lib/context/event.js 598 B
./lib/context/headings/consumer.js 711 B
./lib/context/headings/controller.js 1.14 kB
./lib/context/headings/provider.js 1.23 kB
./lib/DirController.js 569 B
./lib/elements/rh-context-picker/rh-context-picker.js 1.16 kB
./lib/elements/rh-context-provider/rh-context-provider.js 746 B
./lib/functions.js 175 B
./lib/I18nController.js 1.38 kB
./lib/ScreenSizeController.js 856 B

compressed-size-action

@zeroedin zeroedin changed the title add rti to nav slot top level links feat(navigation-secondary): add roving tabindex controller Sep 18, 2023
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L...pretty?GTM

@zeroedin zeroedin marked this pull request as ready for review September 25, 2023 15:25
@bennypowers bennypowers requested a review from nikkimk September 26, 2023 15:28
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. @nikkimk would you please apply your usability expertise here?

Copy link
Collaborator

@brianferry brianferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions about RTI functionality - blocker

@zeroedin
Copy link
Collaborator Author

Questions about RTI functionality - blocker

from @nikkimk in chat:
esc -> closes and sets focus on the last active tab
tab -> closes and sets focus on the next tab
shift+tab -> closes and sets focus on previous tab

Copy link
Collaborator

@brianferry brianferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard navigation in the demo looks good to me, great job!

Copy link
Collaborator

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zeroedin zeroedin enabled auto-merge (squash) October 16, 2023 13:51
@zeroedin zeroedin merged commit f4fcb1f into main Oct 16, 2023
7 checks passed
@zeroedin zeroedin deleted the feat/navigation-secondary/rti branch October 16, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done ☑️
Development

Successfully merging this pull request may close these issues.

5 participants