Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added jspm and redhatstatic cdn examples #1147

Merged
merged 15 commits into from
Nov 27, 2023
Merged

Conversation

heyMP
Copy link
Member

@heyMP heyMP commented Jul 17, 2023

This is a draft PR to support an upcoming developer experience demo. We want to show how you can leverage the CDN / Importmap options when using our library.

Something like this: https://stackblitz.com/edit/web-platform-r96bye?file=index.html

What I did

  1. Added jspm.dev and redhatstatic cdn examples to the code tab of the elements pages.

Needs some prose cleanup and maybe reorganizing.

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

⚠️ No Changeset found

Latest commit: 950d49e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for red-hat-design-system ready!

Name Link
🔨 Latest commit 950d49e
🔍 Latest deploy log https://app.netlify.com/sites/red-hat-design-system/deploys/6564bd4c87dc4c00089b575f
😎 Deploy Preview https://deploy-preview-1147--red-hat-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Size Change: 0 B

Total Size: 210 kB

ℹ️ View Unchanged
Filename Size
./elements/rh-accordion/rh-accordion-header.js 1.98 kB
./elements/rh-accordion/rh-accordion-panel.js 1.24 kB
./elements/rh-accordion/rh-accordion.js 1.17 kB
./elements/rh-alert/rh-alert.js 4.27 kB
./elements/rh-audio-player/rh-audio-player-about.js 1.85 kB
./elements/rh-audio-player/rh-audio-player-scrolling-text-overflow.js 1.51 kB
./elements/rh-audio-player/rh-audio-player-subscribe.js 1.43 kB
./elements/rh-audio-player/rh-audio-player.js 14.2 kB
./elements/rh-audio-player/rh-cue.js 2 kB
./elements/rh-audio-player/rh-transcript.js 2.94 kB
./elements/rh-avatar/random-pattern-controller.js 2.72 kB
./elements/rh-avatar/rh-avatar.js 2.91 kB
./elements/rh-badge/rh-badge.js 1.01 kB
./elements/rh-blockquote/rh-blockquote.js 1.96 kB
./elements/rh-button/rh-button.js 4.39 kB
./elements/rh-card/rh-card.js 1.94 kB
./elements/rh-code-block/rh-code-block.js 1.19 kB
./elements/rh-context-provider/rh-context-provider.js 189 B
./elements/rh-cta/rh-cta.js 4.58 kB
./elements/rh-dialog/rh-dialog.js 1.64 kB
./elements/rh-dialog/yt-api.js 614 B
./elements/rh-footer/rh-footer-block.js 765 B
./elements/rh-footer/rh-footer-copyright.js 362 B
./elements/rh-footer/rh-footer-links.js 1.18 kB
./elements/rh-footer/rh-footer-social-link.js 960 B
./elements/rh-footer/rh-footer-universal.js 4.07 kB
./elements/rh-footer/rh-footer.js 5.08 kB
./elements/rh-footer/rh-global-footer.js 250 B
./elements/rh-menu/rh-menu.js 1.25 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-dropdown.js 2.57 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu-section.js 1.46 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-menu.js 1.9 kB
./elements/rh-navigation-secondary/rh-navigation-secondary-overlay.js 571 B
./elements/rh-navigation-secondary/rh-navigation-secondary.js 5.41 kB
./elements/rh-navigation-secondary/test/fixtures.js 851 B
./elements/rh-pagination/rh-pagination.js 4.46 kB
./elements/rh-spinner/rh-spinner.js 1.61 kB
./elements/rh-stat/rh-stat.js 2.24 kB
./elements/rh-subnav/rh-subnav.js 2.84 kB
./elements/rh-table/rh-sort-button.js 1.31 kB
./elements/rh-table/rh-table.js 2.29 kB
./elements/rh-tabs/rh-tab-panel.js 788 B
./elements/rh-tabs/rh-tab.js 1.83 kB
./elements/rh-tabs/rh-tabs.js 1.86 kB
./elements/rh-tag/rh-tag.js 1.96 kB
./elements/rh-tile/rh-tile-group.js 1.76 kB
./elements/rh-tile/rh-tile.js 4.2 kB
./elements/rh-timestamp/rh-timestamp.js 974 B
./elements/rh-tooltip/rh-tooltip.js 2.24 kB
./lib/context/color/consumer.js 1.15 kB
./lib/context/color/controller.js 1.11 kB
./lib/context/color/provider.js 1.99 kB
./lib/context/event.js 598 B
./lib/context/headings/consumer.js 711 B
./lib/context/headings/controller.js 1.14 kB
./lib/context/headings/provider.js 1.23 kB
./lib/DirController.js 569 B
./lib/elements/rh-context-demo/rh-context-demo.js 1.14 kB
./lib/elements/rh-context-picker/rh-context-picker.js 2.41 kB
./lib/elements/rh-context-provider/rh-context-provider.js 746 B
./lib/functions.js 175 B
./lib/I18nController.js 1.38 kB
./lib/ScreenSizeController.js 856 B
./rhds.min.js 82 kB

compressed-size-action

@heyMP heyMP linked an issue Jul 27, 2023 that may be closed by this pull request
@bennypowers bennypowers marked this pull request as ready for review September 26, 2023 08:51
@bennypowers
Copy link
Member

@marionnegp confirmed. The change I made is not visible in code tabs

I will take a closer look after my holiday

@bennypowers bennypowers enabled auto-merge (squash) October 18, 2023 05:00
@markcaron markcaron self-requested a review November 27, 2023 15:19
Copy link
Collaborator

@markcaron markcaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the installation tabs vertical and box variant.

docs/_plugins/shortcodes/renderInstallation.cjs Outdated Show resolved Hide resolved
Copy link
Collaborator

@markcaron markcaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little Grogu, The Mandalorian

@bennypowers bennypowers merged commit fc27b79 into main Nov 27, 2023
7 checks passed
@bennypowers bennypowers deleted the docs/cdn-import-maps branch November 27, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs]: element installation cdn import map snippets
4 participants