Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Inline promo #566

Closed
2 tasks done
marionnegp opened this issue Oct 4, 2022 · 5 comments · Fixed by #1569
Closed
2 tasks done

[feat] Inline promo #566

marionnegp opened this issue Oct 4, 2022 · 5 comments · Fixed by #1569
Assignees
@adamjohnson @marionnegp
Labels
for dev Ready for development needs discovery Needs discovery needs revisiting Outdated issues worth revisiting in the future new component New component to be created
Milestone
2024/Q2 — Charman...

Comments

@marionnegp
Copy link
Collaborator

marionnegp commented Oct 4, 2022 •
edited by adamjohnson
Loading

Description

The inline promo needs to be formalized as a component because it's being used consistently on .com and will be used as a personalization.

Acceptance Criteria

  • Design done
  • Development done

Image

Featured inline promo:

Image

Standard inline promo:

Image

Full-width promo:

Image

Link to design doc

Figma file

Other resources

No response
@marionnegp marionnegp added for design Design work is requested needs discovery Needs discovery new component New component to be created labels Oct 4, 2022
@marionnegp marionnegp moved this to Backlog in Red Hat Design System Oct 4, 2022
@marionnegp marionnegp changed the title [feat] <Inline promo> [feat] Inline promo Oct 4, 2022
@paigenotfound404 paigenotfound404 added the priority: low Low priority label Dec 12, 2022
@markcaron markcaron removed the Q4 2022 label Sep 15, 2023
@markcaron markcaron added this to the 2023/Q4 — Caterpie release milestone Oct 5, 2023
@markcaron markcaron removed the priority: low Low priority label Oct 5, 2023
@marionnegp marionnegp self-assigned this Oct 6, 2023
@marionnegp marionnegp moved this from Todo to In Progress 🟢 in Red Hat Design System Oct 6, 2023
@bennypowers bennypowers moved this from In Progress 🟢 to Todo in Red Hat Design System Oct 18, 2023
@bennypowers bennypowers moved this from Todo to Backlog in Red Hat Design System Oct 18, 2023
@bennypowers bennypowers moved this from Backlog to Todo in Red Hat Design System Oct 18, 2023
@marionnegp marionnegp moved this from Todo to In Progress 🟢 in Red Hat Design System Oct 19, 2023
@marionnegp
Copy link
Collaborator Author

Questions:

  • The inline promos are basically cards and should maybe be a card variant. How do we define inline promo so RHDS users know when to use promo vs a regular card?
  • Designers like the option to have a promo without a border. This is the use case that full-width promo is trying to capture. Does this make sense to have as a formalized element/pattern in RHDS?

@marionnegp
Copy link
Collaborator Author

@hellogreg @markcaron, since we're still working on documenting correct usage and finding out whether this can extend card accessibly, can this be moved to the Chansey milestone?

@hellogreg
Copy link
Collaborator

@marionnegp Done!

@markcaron markcaron added the needs revisiting Outdated issues worth revisiting in the future label Feb 7, 2024
@marionnegp marionnegp added for dev Ready for development and removed for design Design work is requested labels Apr 4, 2024
@hellogreg hellogreg assigned adamjohnson and unassigned nikkimk May 1, 2024
@adamjohnson
Copy link
Collaborator

@markcaron I'm looking into this component now and Marion asked some great questions.

The inline promos are basically cards and should maybe be a card variant.

Looking at Inline Promo, do you think it should be its own component or should it be an <rh-card> variant or pattern?

@adamjohnson adamjohnson moved this from In Progress 🟢 to Todo in Red Hat Design System May 9, 2024
@bennypowers
Copy link
Member

FWIW I'm leaning towards card variant. Can we maybe put together a PoC and shop it around to studio devs?

@adamjohnson adamjohnson mentioned this issue May 15, 2024
Merged
@adamjohnson adamjohnson linked a pull request May 16, 2024 that will close this issue
feat(card): promo variant #1569
Merged
@adamjohnson adamjohnson mentioned this issue May 16, 2024
Closed
@hellogreg hellogreg moved this from Todo to In Progress 🟢 in Red Hat Design System May 30, 2024
@hellogreg hellogreg moved this from Todo to In Progress 🟢 in Red Hat Design System Roadmap May 30, 2024
@adamjohnson adamjohnson moved this from In Progress 🟢 to Review 🔍 in Red Hat Design System Jun 7, 2024
@adamjohnson adamjohnson moved this from In Progress 🟢 to Review 🔍 in Red Hat Design System Roadmap Jun 7, 2024
@github-project-automation github-project-automation bot moved this from Review 🔍 to Done ☑️ in Red Hat Design System Roadmap Aug 8, 2024
@github-project-automation github-project-automation bot moved this from Review 🔍 to Done ☑️ in Red Hat Design System Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjohnson adamjohnson

@marionnegp marionnegp

Labels
for dev Ready for development needs discovery Needs discovery needs revisiting Outdated issues worth revisiting in the future new component New component to be created
Projects
Red Hat Design System
Status: Done ☑️
Red Hat Design System Roadmap
Status: Done ☑️
Milestone
2024/Q2 — Charmander release
Development

Successfully merging a pull request may close this issue.

feat(card): promo variant RedHat-UX/red-hat-design-system
9 participants
@adamjohnson @hellogreg @bennypowers @markcaron @nikkimk @coreyvickery @marionnegp @methomps @paigenotfound404