Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <rh-blockquote> has inline margins without emphasis border #1332

Closed
marionnegp opened this issue Nov 10, 2023 · 0 comments · Fixed by #1335
Closed

[bug] <rh-blockquote> has inline margins without emphasis border #1332

marionnegp opened this issue Nov 10, 2023 · 0 comments · Fixed by #1335
Assignees
Labels
bug Something isn't working

Comments

@marionnegp
Copy link
Collaborator

Describe the bug

A margin is getting added to the left of <rh-blockquote> that prevents it from being properly aligned to the text.

Which Component?

rh-blockquote

Steps to reproduce

Try adding text to the rh-blockquote.html demo file.

Expected behaviour

Blockquote shouldn't have a left margin if there's no emphasis border.

Screenshots

Current

image (3)

Expected

image (4)

Looks like a user agent stylesheet is adding an inline margin to <figure>, at least in our demos.
Screenshot 2023-11-10 at 1 36 34 PM

Element HTML

No response

Operating System (OS)

macOS

Browser

No response

More browser information

No response

Additional Info

@markcaron said to consider:

  1. Purposefully setting or resetting the padding (as it seems to not do either at all)

  2. Adding a custom CSS var to adjust (in Aly’s case)

Not sure if it needs a CSS part, but we might consider adding one of the devs think it makes sense

@marionnegp marionnegp added the bug Something isn't working label Nov 10, 2023
bennypowers added a commit that referenced this issue Nov 12, 2023
@bennypowers bennypowers moved this from Backlog to In Progress 🟢 in Red Hat Design System Nov 12, 2023
@bennypowers bennypowers self-assigned this Nov 12, 2023
bennypowers added a commit that referenced this issue Nov 14, 2023
@github-project-automation github-project-automation bot moved this from In Progress 🟢 to Done ☑️ in Red Hat Design System Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done ☑️
Development

Successfully merging a pull request may close this issue.

2 participants