Skip to content

Commit

Permalink
chore: fix changesets (#1785)
Browse files Browse the repository at this point in the history
* chore: fix rh-switch changeset

* chore: fix `rh-tile` changeset

* fix(cta): update changeset to major

* fix(cta): remove duplicate changeset

* docs: changeset

* docs(footer): combine footer changesets

* docs: update changeset

* docs(footer): changeset

* docs(table): update changeset formatting and switch to major

* fix(tabs)!: remove deprecated attrs from rh-tab

* fix(footer): remove deprecated css

* docs: dont bold before / after changeset text

* fix(dialog)!: deprecated css

---------

Co-authored-by: Adam Johnson <[email protected]>
Co-authored-by: Benny Powers <[email protected]>
Co-authored-by: Benny Powers - עם ישראל חי! <[email protected]>
  • Loading branch information
4 people authored Aug 27, 2024
1 parent 8a061e9 commit 8e68a6a
Show file tree
Hide file tree
Showing 17 changed files with 146 additions and 92 deletions.
26 changes: 24 additions & 2 deletions .changeset/breezy-turkeys-clean.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,27 @@
---
"@rhds/elements": patch
"@rhds/elements": major
---

`<rh-footer>`: removed deprecated `global` slot, use `universal` slot
`<rh-footer>`: removed deprecated `<rh-global-footer>` element and deprecated `global` slot. Use `<rh-footer-universal>` element and `universal` slot.

Before:

```html
<rh-footer>
<!-- ... -->
<rh-global-footer slot="global">
<!-- ... -->
</rh-global-footer>
</rh-footer>
```

After:

```html
<rh-footer>
<!-- ... -->
<rh-footer-universal slot="universal">
<!-- ... -->
</rh-footer-universal>
</rh-footer>
```
4 changes: 2 additions & 2 deletions .changeset/cyan-dragons-care.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
"@rhds/elements": patch
"@rhds/elements": major
---

`<rh-cta>`: removed deprecated read-only `cta` property; use `data-analytics` attributes instead
`<rh-cta>`: removed read-only `cta` property; use `data-analytics` attributes instead
20 changes: 20 additions & 0 deletions .changeset/legal-coins-happen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
"@rhds/elements": major
---
`<rh-dialog>`: removed deprecated `--rh-modal-video-aspect-ratio` CSS custom property

Before:

```css
rh-dialog.custom-dialog {
--rh-modal-video-aspect-ratio: 3/2;
}
```

After:

```css
rh-dialog.custom-dialog {
--rh-dialog-video-aspect-ratio: 3/2;
}
```
24 changes: 24 additions & 0 deletions .changeset/little-readers-fail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
"@rhds/elements": major
---
`<rh-footer>`: removed deprecated CSS custom properties

Before:

```css
rh-footer.custom-footer {
--rh-color-link-inline-on-dark: cyan;
--rh-color-link-inline-hover-on-dark: cornflowerblue;
--rh-color-link-inline-focus-on-dark: cornflowerblue;
--rh-color-link-inline-visited-on-dark: cornflowerblue;
}
```

After:

```css
rh-footer.custom-footer {
--rh-color-interactive-blue-lighter: cyan;
--rh-color-interactive-blue-lightest: cornflowerblue;
}
```
18 changes: 16 additions & 2 deletions .changeset/many-foxes-invent.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
---
"@rhds/elements": patch
"@rhds/elements": major
---

`<rh-spinner>`: remove deprecated color-palette property
`<rh-spinner>`: remove deprecated `color-palette` attribute

Before:

```html
<rh-spinner color-palette="darkest"></rh-spinner>
```

After:

```html
<rh-surface color-palette="darkest">
<rh-spinner></rh-spinner>
</rh-surface>
```
5 changes: 0 additions & 5 deletions .changeset/mighty-vans-skate.md

This file was deleted.

44 changes: 23 additions & 21 deletions .changeset/odd-bugs-repair.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,29 @@
---
"@rhds/elements": minor
"@rhds/elements": major
---

`<rh-alert>`: removed deprecated toast boolean attribute

Before:
```html
<rh-alert toast>
<h3 slot="header">Default</h3>
<p>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam eleifend
elit sed est egestas, a sollicitudin mauris tincidunt.
</p>
</rh-alert>
```
Before:

After:
```html
<rh-alert variant="toast">
<h3 slot="header">Default</h3>
<p>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam eleifend
elit sed est egestas, a sollicitudin mauris tincidunt.
</p>
</rh-alert>
```
```html
<rh-alert toast>
<h3 slot="header">Default</h3>
<p>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam eleifend
elit sed est egestas, a sollicitudin mauris tincidunt.
</p>
</rh-alert>
```

After:

```html
<rh-alert variant="toast">
<h3 slot="header">Default</h3>
<p>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam eleifend
elit sed est egestas, a sollicitudin mauris tincidunt.
</p>
</rh-alert>
```
20 changes: 19 additions & 1 deletion .changeset/pretty-scissors-cough.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
---
"@rhds/elements": patch
"@rhds/elements": major
---

`<rh-table>`: removed deprecated CSS custom properties

Before:

```css
rh-table.custom-table {
--rh-table-row-background-color: crimson;
--rh-table-column-background-color: royalblue;
}
```

After:

```css
rh-table.custom-table {
--rh-table-row-background-hover-color: crimson;
--rh-table-column-background-hover-color: royalblue;
}
```
5 changes: 0 additions & 5 deletions .changeset/sixty-jokes-judge.md

This file was deleted.

8 changes: 8 additions & 0 deletions .changeset/smooth-suns-cough.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@rhds/elements": major
---
`<rh-tabs>`: removed `box` and `vertical` attributes from `<rh-tab>`. Set them
on `<rh-tabs>` instead.

In most cases, you shouldn't need to update your templates, as long as `<rh-tabs>`
has the right attributes
2 changes: 1 addition & 1 deletion .changeset/tiny-melons-help.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"@rhds/elements": patch
---

Fixed the headline, title, body text, and footer font-sizes to match the Tile specs for both the default and compact variants
`<rh-tile>`: Fixed the headline, title, body text, and footer font-sizes to match the Tile specs for both the default and compact variants
2 changes: 1 addition & 1 deletion .changeset/wild-steaks-play.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

A switch toggles the state of a setting (between on and off). Switches and checkboxes can often be used interchangeably, but the switch provides a more explicit, visible representation on a setting.

html```
```html
<rh-switch id="switch-a"
accessible-label="Switch A"
checked>
Expand Down
8 changes: 2 additions & 6 deletions elements/rh-dialog/rh-dialog.css
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,7 @@ footer {
}

:host([type="video"][open]) [part="dialog"] {
/* TODO remove --rh-modal-video-aspect-ratio for v2 */
/* stylelint-disable-next-line */
--_aspect-ratio: var(--rh-dialog-video-aspect-ratio, var(--rh-modal-video-aspect-ratio, 16/9));
--_aspect-ratio: var(--rh-dialog-video-aspect-ratio, 16/9);

aspect-ratio: var(--_aspect-ratio);
max-width: min(90%, calc(90vh * var(--_aspect-ratio) + var(--offset-top)));
Expand All @@ -186,9 +184,7 @@ footer {
:host([type="video"]) #container,
:host([type="video"]) [part="content"],
:host([type="video"]) ::slotted(:not([slot])) {
/* TODO remove --rh-modal-video-aspect-ratio for v2 */
/* stylelint-disable-next-line */
aspect-ratio: var(--rh-dialog-video-aspect-ratio, var(--rh-modal-video-aspect-ratio, 16/9));
aspect-ratio: var(--rh-dialog-video-aspect-ratio, 16/9);

/* account for a 1px descrepency between dialog and container aspect ratio */
width: calc(100% + 1px);
Expand Down
16 changes: 4 additions & 12 deletions elements/rh-footer/rh-footer-lightdom.css
Original file line number Diff line number Diff line change
@@ -1,28 +1,20 @@
:is(rh-footer, rh-footer-universal) a {
/* TODO remove --rh-color-link-inline-on-dark for v2 */
/* stylelint-disable-next-line */
color: var(--rh-color-link-inline-on-dark, var(--rh-color-interactive-blue-lighter, #92c5f9));
color: var(--rh-color-interactive-blue-lighter, #92c5f9);
text-decoration: none;
}

:is(rh-footer, rh-footer-universal) a:hover {
/* TODO remove --rh-color-link-inline-hover-on-dark for v2 */
/* stylelint-disable-next-line */
color: var(--rh-color-link-inline-hover-on-dark, var(--rh-color-interactive-blue-lightest, #b9dafc));
color: var(--rh-color-interactive-blue-lightest, #b9dafc);
text-decoration: underline;
}

:is(rh-footer, rh-footer-universal) a:is(:focus, :focus-within) {
/* TODO remove --rh-color-link-inline-focus-on-dark for v2 */
/* stylelint-disable-next-line */
color: var(--rh-color-link-inline-focus-on-dark, var(--rh-color-interactive-blue-lightest, #b9dafc));
color: var(--rh-color-interactive-blue-lightest, #b9dafc);
text-decoration: underline;
}

:is(rh-footer, rh-footer-universal) a:visited {
/* TODO remove --rh-color-link-inline-visited-on-dark for v2 */
/* stylelint-disable-next-line */
color: var(--rh-color-link-inline-visited-on-dark, var(--rh-color-interactive-blue-lightest, #b9dafc));
color: var(--rh-color-interactive-blue-lightest, #b9dafc);
text-decoration: none;
}

Expand Down
Loading

0 comments on commit 8e68a6a

Please sign in to comment.