perf(cta): lazy-load icon dependency

RedHat-UX · Jun 17, 2024 · 879dfb7 · 879dfb7
1 parent 6474df5
commit 879dfb7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/few-buckets-cross.md b/.changeset/few-buckets-cross.md
@@ -0,0 +1,4 @@
+---
+"@rhds/elements": patch
+---
+`<rh-cta>`: lazy-load the icon component dependency
diff --git a/elements/rh-cta/rh-cta.ts b/elements/rh-cta/rh-cta.ts
@@ -12,8 +12,6 @@ import { colorContextConsumer, type ColorTheme } from '../../lib/context/color/c
 
 import style from './rh-cta.css';
 
-import '@patternfly/elements/pf-icon/pf-icon.js';
-
 export interface CtaData {
   href?: string;
   text?: string;
@@ -147,6 +145,13 @@ export class RhCta extends LitElement {
 
   #logger = new Logger(this);
 
+  protected override async getUpdateComplete(): Promise<boolean> {
+    if (this.icon) {
+      await import('@patternfly/elements/pf-icon/pf-icon.js');
+    }
+    return super.getUpdateComplete();
+  }
+
   get #isDefault(): boolean {
     return !this.hasAttribute('variant');
   }