Skip to content

Commit

Permalink
docs(subnav): fix typos in "Best practices" section
Browse files Browse the repository at this point in the history
  • Loading branch information
marionnegp committed Dec 2, 2024
1 parent 3d1c080 commit 80110a2
Showing 1 changed file with 4 additions and 28 deletions.
32 changes: 4 additions & 28 deletions elements/rh-subnav/docs/20-guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -223,30 +223,6 @@ labels.
<p>Subnavigation should always appear below the primary navigation.</p>
</uxdot-best-practice>

<uxdot-best-practice variant="dont">
<uxdot-example slot="image" width-adjustment="1012px">
<img src="../subnav-best-practices-nav-order-dont"
alt="Subnavigation positioned above primary nav"
width="1012"
height="134">
</uxdot-example>

<p>Do not position the subnavigation above the primary navigation.</p>
</uxdot-best-practice>

### Navigation order

<uxdot-best-practice variant="do">
<uxdot-example slot="image" width-adjustment="1012px">
<img src="../subnav-best-practices-nav-order-do.svg"
alt="Subnavigation positioned below primary nav"
width="1012"
height="134">
</uxdot-example>

<p>Subnavigation should always appear below the primary navigation.</p>
</uxdot-best-practice>

<uxdot-best-practice variant="dont">
<uxdot-example slot="image" width-adjustment="1012px">
<img src="../subnav-best-practices-nav-order-dont.svg"
Expand All @@ -262,7 +238,7 @@ labels.

<div class="grid sm-two-columns">
<uxdot-best-practice variant="do">
<uxdot-example slot="image" color-palette="darkest" width-adjustment="418px">
<uxdot-example slot="image" width-adjustment="418px">
<img src="../subnav-best-practices-min-links-do.svg"
alt="Subnavigation with two links"
width="418"
Expand All @@ -272,7 +248,7 @@ labels.
</uxdot-best-practice>

<uxdot-best-practice variant="dont">
<uxdot-example slot="image" color-palette="darkest" width-adjustment="418px">
<uxdot-example slot="image" width-adjustment="418px">
<img src="../subnav-best-practices-min-links-dont.svg"
alt="Subnavigation with one link"
width="418"
Expand All @@ -292,7 +268,7 @@ labels.
height="56">
</uxdot-example>

<p>Use a reasonable number of links.</p>
<p>There is no specific maximum number of links, but use a reasonable number of links.</p>
</uxdot-best-practice>

<uxdot-best-practice variant="dont">
Expand Down Expand Up @@ -351,5 +327,5 @@ labels.
height="56">
</uxdot-example>

<p>Do not add extra spacing or stretch the width of links.</p>
<p>Do not make overflow buttons visible if all links can comfortably fit and are visible.</p>
</uxdot-best-practice>

0 comments on commit 80110a2

Please sign in to comment.