fix(cta): remove deprecated public getter (#1767)

* fix(cta): remove deprecated public getter * chore(cta): add changeset * refactor(cta): remove private getter * docs: changesset --------- Co-authored-by: Benny Powers <[email protected]>
RedHat-UX · Aug 20, 2024 · 12a8f75 · 12a8f75
1 parent 347d29e
commit 12a8f75
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 17 deletions.
diff --git a/.changeset/cyan-dragons-care.md b/.changeset/cyan-dragons-care.md
@@ -0,0 +1,5 @@
+---
+"@rhds/elements": patch
+---
+
+`<rh-cta>`: removed deprecated read-only `cta` property; use `data-analytics` attributes instead
diff --git a/elements/rh-cta/rh-cta.ts b/elements/rh-cta/rh-cta.ts
@@ -127,22 +127,6 @@ export class RhCta extends LitElement {
     return super.getUpdateComplete();
   }
 
-  /**
-   * The slotted `<a>` or `<button>` element
-   * @deprecated use `data-analytics-` attributes instead
-   */
-  public get cta(): HTMLAnchorElement | HTMLButtonElement | null {
-    return this.#cta;
-  }
-
-  get #cta() {
-    return (
-      this.shadowRoot?.querySelector('a')
-      ?? this.shadowRoot?.querySelector('slot')?.assignedElements().find(isSupportedContent)
-      ?? null
-    );
-  }
-
   /** Is the element in an RTL context? */
   #dir = new DirController(this);
 
@@ -189,7 +173,11 @@ export class RhCta extends LitElement {
 
   override firstUpdated() {
     const { href, variant } = this;
-    const cta = this.#cta;
+    const cta =
+         this.shadowRoot?.querySelector('a')
+      ?? this.shadowRoot?.querySelector('slot')?.assignedElements().find(isSupportedContent)
+      ?? null;
+
     if (href && cta !== this.shadowRoot?.querySelector('a')) {
       return this.#logger.warn(`When the href attribute is used, slotted content must not be a link`);
     } else if (!href && !cta) {