Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature padding stack view #5

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

huy-ras
Copy link
Collaborator

@huy-ras huy-ras commented Dec 7, 2022

Add padding to UIStackView:

  • theme_paddingLeft
  • theme_paddingTop
  • theme_paddingRight
  • theme_paddingBottom
  • theme_paddingVertical
  • theme_paddingHorizontal
  • theme_padding

@huy-ras huy-ras requested a review from ryantan December 7, 2022 06:16
@ryantan
Copy link

ryantan commented Dec 7, 2022

@huy-ras no issues with the code, but wondering if it should be on UIView. For setting isLayoutMarginsRelativeArrangement, maybe can check if the view is an instance/subclass of UIStackView and calling there. wdyt

@huy-ras
Copy link
Collaborator Author

huy-ras commented Dec 7, 2022

@ryantan not sure if UIView also set up the constraints. I think should keep this simple just for stack view and for UIView that should be the constraints constant instead. Also maybe can check if the view is an instance/subclass of UIStackView I'm just think about loop all subviews -> not sure about performance.

@ryantan
Copy link

ryantan commented Dec 7, 2022

I think should keep this simple just for stack view and for UIView that should be the constraints constant instead

ok agreed.

I'm just think about loop all subviews -> not sure about performance.

Not looping through subviews, just the view theme_** is applied on.

@ryantan ryantan merged commit 734cd44 into master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants