fix: still sort when search value is absent

fix kentcdodds#100
RebeccaStevens · Sep 14, 2020 · ecc38a9 · ecc38a9
1 parent cad3220
commit ecc38a9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/__tests__/index.js b/src/__tests__/index.js
@@ -361,7 +361,7 @@ const tests = {
       'superduperfile',
     ],
   },
-  'skip matching when no search value is absent': {
+  'sort when search value is absent': {
     input: [
       [
         {tea: 'Milk', alias: 'moo'},
@@ -372,9 +372,9 @@ const tests = {
       {keys: ['tea']},
     ],
     output: [
+      {tea: 'Green', alias: 'C'},
       {tea: 'Milk', alias: 'moo'},
       {tea: 'Oolong', alias: 'B'},
-      {tea: 'Green', alias: 'C'},
     ],
   },
   'only match when key meets threshold': {

diff --git a/src/index.js b/src/index.js
@@ -41,9 +41,6 @@ const defaultBaseSortFn = (a, b) =>
  * @return {Array} - the new sorted array
  */
 function matchSorter(items, value, options = {}) {
-  // not performing any search/sort if value(search term) is empty
-  if (!value) return items
-
   const {
     keys,
     threshold = rankings.MATCHES,