REC TC decision 1/11/24 - resolution to issue #252 and #244 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ves the target restriction on System:includes.
cbupp
changed the title
PeteHart
approved these changes
Jan 12, 2024
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution to #252 - To align to the W3C Organization Ontology, it was determined that
memberOfis preferred toisMemberOf. Since simply renaming would be considered a breaking change, we've decided to create a ODR for deprecating model content (properties and relationships) and implement those decisions on theisMemberOfrelationship and create the newmemberOfrelationship.Resolution to #244 - System.includes removes the target restriction so that Loops, points, and equipment can be included. This aligns to Brick's usage of System.hasPart. (Though, REC uses
includesinstead ofhasPartfor collections, because hasPart is overloaded in it's usage for both inclusion and part-hood.)