Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Dev to Main Sync" #950

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Revert "Dev to Main Sync" #950

merged 1 commit into from
Oct 24, 2024

Conversation

lakshayman
Copy link
Contributor

Reverting this PR as it has security issues. The phoneNumber field is visible to everyone and it is not obfuscated. There is mismatch subscribe storing phoneNumber in user data but we have a field named phone in user data already that is obfuscated and secured.

Please fix that in design doc as well

@lakshayman lakshayman self-assigned this Oct 24, 2024
@lakshayman lakshayman merged commit 27d5a3b into main Oct 24, 2024
3 checks passed
@lakshayman lakshayman deleted the revert-949-develop branch October 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants