-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/user data pagination #891
base: develop
Are you sure you want to change the base?
Feature/user data pagination #891
Conversation
… we scroll, changed data fetching structure to fetch last user id
…ot visible in screen
… we scroll, changed data fetching structure to fetch last user id
…ot visible in screen
…anVeer/website-dashboard into feature/user-data-pagination
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put your feature behind feature flag also remove the mock data and comments
and what about the paginate API?
Hey who is working on backend for this? |
…ashboard into feature/user-data-pagination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- can you please attach test coverage of the App.test.js
- also please attach a video of changes working with dev flag
…ashboard into feature/user-data-pagination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor addition, I believe rest of the things are good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How you will test your feature on staging and prod?
// add feature flag(feature should be only visible when query params dev=true) | ||
|
||
export const paginateFetchedUsers = async (tabId, page = 1) => { | ||
if (isLoading) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How you are checking this condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked it with mock data, so when data is not being loaded the loading spinner is rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how did you determine isLoading and where are you getting this from ?
Will take up task to work on backend and then merge both the tasks. |
So start working on the backend first |
Date: 15/10/2024
Developer Name: Ishan Veer
Issue Ticket Number
Description
Previously all the data was being fetched at once which can cause performance issues. So things I worked on:
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes
Currently testing it with mock data because API is still not paginated.