Auctions page: create new auction, make bid on existing auctions #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swarajpure
added
the
feature task
swarajpure
requested review from
ankushdharkar,
sumitd94,
SBagaria2710,
correaswebert,
Kratika0907,
Rucha1499 and
sanyogita14
sumitd94
suggested changes
Mar 10, 2021
|
LGTM 👍🏼 |
swarajpure
commented
Mar 11, 2021
sumitd94
reviewed
Mar 11, 2021
Comment on lines
+92
to
+109
| .biddersImg[data-columns="2"]{ | ||
| width: calc(160px/2); | ||
| } | ||
| .biddersImg[data-columns="3"]{ | ||
| width: calc(160px/3); | ||
| } | ||
| .biddersImg[data-columns="4"]{ | ||
| width: calc(160px/4); | ||
| } | ||
| .biddersImg[data-columns="5"]{ | ||
| width: calc(160px/5); | ||
| } | ||
| .biddersImg[data-columns="6"]{ | ||
| width: calc(160px/6); | ||
| } | ||
| .biddersImg[data-columns="7"]{ | ||
| width: calc(160px/7); | ||
| } |
There was a problem hiding this comment.
Here we are changing the size of the bidder's image
Size of the bidder's Image-based on the number of columns allowed in the container horizontally.
There was a problem hiding this comment.
Why not use a declarative class or an inline sizing?
components/Auctions/index.js
Outdated
|
|
||
| const handleNewBid = async (e, auctionId) => { | ||
| if (!isUserLoggedIn) { | ||
| return alert('Please log in to bid!'); |
There was a problem hiding this comment.
NIT:
alert();
return;
| }; | ||
|
|
||
| const getColumns = (totalBidder) => { | ||
| return totalBidder <= 12 ? Math.ceil(totalBidder / 2) : 7; |
There was a problem hiding this comment.
MAX_ALLOWED_COLUMNS=7
MAX_BIDDERS_ALLOWED_BELOW_MAX_COLUMNS=12
harshith-venkatesh
approved these changes
Mar 13, 2021
|
If all comments are resolved, time to ship this! 🚢 |
swarajpure
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Real-Dev-Squad/todo-action-items#16
Unable to add GIF preview here due to size limitation.
Please check preview here: https://cdn.discordapp.com/attachments/748267291405320204/820029342876827658/auctions_gif.gif
Subsequent PRs to improve the feature/fix bugs: