Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape non-ascii characters in json payloads. #40

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Escape non-ascii characters in json payloads. #40

merged 2 commits into from
Mar 30, 2020

Conversation

RobFaie
Copy link
Contributor

@RobFaie RobFaie commented Mar 29, 2020

Even if the content type indicates a valid unicode charset, Zendesk does like non-ascii characters that aren't escaped.

PS 6.2 added the -EscapeHanding parameter to ConvertTo-Json which can be used.

Even if the content type indicates a valid unicode charset, Zendesk does like non-ascii characters that aren't escaped.

PS 6.2 added the `-EscapeHanding` parameter to `ConvertTo-Json` which can be used.
@RobFaie RobFaie force-pushed the encoding branch 2 times, most recently from b8abd7f to e3b3965 Compare March 29, 2020 11:33
@RobFaie
Copy link
Contributor Author

RobFaie commented Mar 29, 2020

Windows 2016 / PS 5.1 is having some issues. I will take a look tomorrow.

Copy link
Contributor

@mderriey mderriey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Rob!

This will fix failing tests on Windows 2016 / PS 5.1
@RobFaie RobFaie merged commit eaca1bb into master Mar 30, 2020
@RobFaie RobFaie deleted the encoding branch March 30, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants