Merge pull request #15 from Readify/group-memberships

Adds role assertions and route tests to group membership functions
Readify · Feb 19, 2020 · 65f2cb0 · 65f2cb0
2 parents 89f0a5f + 7b5cb7e
commit 65f2cb0
Show file tree

Hide file tree

Showing 5 changed files with 524 additions and 11 deletions.
diff --git a/functions/Get-GroupMembership.ps1 b/functions/Get-GroupMembership.ps1
@@ -8,6 +8,8 @@ function Get-GroupMembership {
         # Unique Id of the group membership to retrieve
         [Parameter(Mandatory = $true,
             ParameterSetName = 'Id')]
+        [Parameter(Mandatory = $false,
+            ParameterSetName = 'UserId')]
         [ValidateRange(1, [Int64]::MaxValue)]
         [Int64]
         $Id,
@@ -51,6 +53,8 @@ function Get-GroupMembership {
         $Context = $null
     )
 
+    Assert-IsAgent -Context $Context
+
     $key = 'group_memberships'
 
     switch ($PSCMDlet.ParameterSetName) {
@@ -60,7 +64,11 @@ function Get-GroupMembership {
         }
 
         'UserId' {
-            $path = "/api/v2/users/$UserId/group_memberships.json"
+            if ($PSBoundParameters.ContainsKey('Id')) {
+                $path = "/api/v2/users/$UserId/group_memberships/$Id.json"
+            } else {
+                $path = "/api/v2/users/$UserId/group_memberships.json"
+            }
         }
 
         'GroupId' {

diff --git a/functions/New-GroupMembership.ps1 b/functions/New-GroupMembership.ps1
@@ -6,35 +6,60 @@ function New-GroupMembership {
     Param (
 
         # The id of an agent
-        [Parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true,
+            ParameterSetName = 'Properties')]
         [ValidateRange(1, [Int64]::MaxValue)]
         [Int64]
         $UserId,
 
         # The id of a group
-        [Parameter(Mandatory = $true)]
+        [Parameter(Mandatory = $true,
+            ParameterSetName = 'Properties')]
         [ValidateRange(1, [Int64]::MaxValue)]
         [Int64]
         $GroupId,
 
         # If true, tickets assigned directly to the agent will assume this membership's group.
-        [Parameter(Mandatory = $false)]
+        [Parameter(Mandatory = $false,
+            ParameterSetName = 'Properties')]
         [Switch]
         $Default,
 
+        [Parameter(Mandatory = $true,
+            ParameterSetName = 'Object')]
+        [ValidateNotNullOrEmpty()]
+        [PSCustomObject[]]
+        $Membership,
+
         # Zendesk Connection Context from `Get-ZendeskConnection`
         [Parameter(Mandatory = $false)]
         [PSTypeName('ZendeskContext')]
         [PSCustomObject]
         $Context = $null
     )
 
-    $path = 'api/v2/group_memberships.json'
-    $body = @{
-        group_membership = @{
-            user_id  = $UserId
-            group_id = $GroupId
-            default  = $Default
+    Assert-IsAdmin -Context $Context
+
+    if ($PSCmdlet.ParameterSetName -eq 'Properties') {
+        $path = "/api/v2/users/$UserId/group_memberships.json"
+        $body = @{
+            group_membership = @{
+                user_id  = $UserId
+                group_id = $GroupId
+                default  = $Default
+            }
+        }
+    } else {
+        if ($Membership.Count -gt 1) {
+            $path = '/api/v2/group_memberships/create_many.json'
+            $body = @{
+                group_memberships = $Membership
+            }
+        } else {
+            $path = '/api/v2/group_memberships.json'
+            $body = @{
+                group_membership = $Membership
+            }
         }
     }
 

diff --git a/functions/Remove-GroupMembership.ps1 b/functions/Remove-GroupMembership.ps1
@@ -12,18 +12,30 @@ function Remove-GroupMembership {
         [Int64[]]
         $Id,
 
+        # The id of the user to remove group membership for
+        [Parameter(Mandatory = $false)]
+        [ValidateRange(1, [Int64]::MaxValue)]
+        [Int64]
+        $UserId,
+
         # Zendesk Connection Context from `Get-ZendeskConnection`
         [Parameter(Mandatory = $false)]
         [PSTypeName('ZendeskContext')]
         [PSCustomObject]
         $Context = $null
     )
 
+    Assert-IsAdmin -Context $Context
+
     if ($Id.count -gt 1) {
         $ids = $Id -join ','
         $path = "/api/v2/group_memberships/destroy_many.json?ids=$ids"
     } else {
-        $path = "/api/v2/group_memberships/$Id.json"
+        if ($PSBoundParameters.ContainsKey('UserId')) {
+            $path = "/api/v2/users/$UserId/group_memberships/$Id.json"
+        } else {
+            $path = "/api/v2/group_memberships/$Id.json"
+        }
     }
 
     if ($PSCmdlet.ShouldProcess("$Id", 'Delete Group Memberships')) {

diff --git a/functions/Set-GroupMembershipAsDefault.ps1 b/functions/Set-GroupMembershipAsDefault.ps1
@@ -26,6 +26,8 @@ function Set-GroupMembershipAsDefault {
         $Context = $null
     )
 
+    Assert-IsAgent -Context $Context
+
     $path = "/api/v2/users/$UserId/group_memberships/$MembershipId/make_default.json"
 
     if ($PSCmdlet.ShouldProcess($UserId, "Set default group: $MembershipId")) {