Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for thisArgs issue #992

Merged
merged 2 commits into from
Dec 8, 2015
Merged

Updates for thisArgs issue #992

merged 2 commits into from
Dec 8, 2015

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Dec 8, 2015

  • removes thisArgs from skipWhile
  • adds thisArgs to forEach
  • removes some thisArgs cruft from CoreOperators interface.
  • eliminates some closure in the forEach method

@benlesh
refactor(skipWhile): remove thisArg argument
d8f7297 
- removes thisArg and tests around that from skipWhile
- removes extra thisArg on interface defs for first and last as well

BREAKING CHANGE: skipWhile no longer accepts a thisArg argument
related #878
@benlesh
feat(forEach): add thisArg
14ffce6 
- adds thisArg as second argument to have symmetry with native Array forEach
- eliminates closures by leveraging named function instances
- adds test for thisArg passing
- updates tests to accommodate thisArg

BREAKING CHANGE: Observable.prototype.forEach argument order changed to accommodate thisArg. Optional PromiseCtor argument moved to third arg from second
closes #878
@benlesh
Copy link
Member Author

benlesh commented Dec 8, 2015

This should close #878

@kwonoj
Copy link
Member

kwonoj commented Dec 8, 2015

Changes look good to me.

@benlesh benlesh merged commit 14ffce6 into ReactiveX:master Dec 8, 2015
@benlesh
Copy link
Member Author

benlesh commented Dec 8, 2015

Thanks for the review @kwonoj

@benlesh benlesh deleted the remove_thisArgs branch April 27, 2016 17:20
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlesh @kwonoj