Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(takeWhile): remove thisArg #882

Closed
wants to merge 1 commit into from
Closed

feat(takeWhile): remove thisArg #882

wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Dec 3, 2015

relates to #878

This PR tries to take out thisArg from takeWhile operator.

@staltz
Copy link
Member

staltz commented Dec 4, 2015

Looks good

@kwonoj
Copy link
Member Author

kwonoj commented Dec 4, 2015

I'll leave this PR around half day to see if there's suggestion before check in.

@kwonoj
Copy link
Member Author

kwonoj commented Dec 4, 2015

PR is updated to remove bindCallback also. I'll continue effort to get rid of thisArg from operators as well as bindCallback itself as last step.

@benlesh
Copy link
Member

benlesh commented Dec 4, 2015

Merged with b5219a4 ... thanks @kwonoj

@benlesh benlesh closed this Dec 4, 2015
@kwonoj kwonoj deleted the feat-takewhile branch December 4, 2015 23:20
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwonoj @staltz @benlesh