Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bindCallback): rename fromCallback, add tests, and fix/refactor #881

Merged
merged 3 commits into from
Dec 4, 2015
Merged

feat(bindCallback): rename fromCallback, add tests, and fix/refactor #881

merged 3 commits into from
Dec 4, 2015

Commits on Dec 4, 2015

  1. feat(bindCallback): rename fromCallback to bindCallback 

    since fromCallback does not behave in a manner consistent with other fromX methods, it is being renamed to bindCallback as it returns a bound function that returns an observable

closes #876
    @benlesh
    benlesh committed Dec 4, 2015
    Configuration menu
    Copy the full SHA
    305d66d View commit details
    Browse the repository at this point in the history

  2. feat(bindCallback): remove thisArg 

    thisArg is removed as this method does not mirror any native function with a thisArg

related #878
    @benlesh
    benlesh committed Dec 4, 2015
    Configuration menu
    Copy the full SHA
    feea9a1 View commit details
    Browse the repository at this point in the history

  3. fix(bindCallback): only call function once even while scheduled 

    The previous implementation had issues with only calling the source function one time when scheduled. Since bindCallback shares its result with all subscribers, it is multicast, that means that it would need to maintain a list of subscribers internally. In leiu of that, I'm using AsyncSubject (which might need a better name)

closes #881
    @benlesh
    benlesh committed Dec 4, 2015
    Configuration menu
    Copy the full SHA
    8637d47 View commit details
    Browse the repository at this point in the history