feat(BehaviorSubject): add getValue method to access value #853

benlesh · 2015-12-01T19:58:03Z

adds getValue method to get inner value
further hides the value as _value
adds value property getter
purposefully excludes value property setter
adds tests around getValue method and value property

fixes #758

kwonoj · 2015-12-02T03:21:56Z

src/Rx.ts

@@ -110,7 +110,7 @@ import {ConnectableObservable} from './observable/ConnectableObservable';
 import {Notification} from './Notification';
 import {EmptyError} from './util/EmptyError';
 import {ArgumentOutOfRangeError} from './util/ArgumentOutOfRangeError';
-import {nextTick} from './scheduler/nextTick';
+import {ObjectUnsubscribedError} from './util/ObjectUnsubscribedError';


Build failed by removing importing nextTick in here still being used in line 121.

kwonoj · 2015-12-02T03:22:31Z

Change looks good to me except missing nextTick makes build failed.

- adds `getValue` method to get inner value - further hides the value as `_value` - adds `value` property getter - purposefully excludes `value` property setter - adds tests around `getValue` method and `value` property fixes #758

this class was added to support throwing errors when members of Subjects were accessed in invalid ways after the Subject has been unsubscribed related #859 related #758

…scription related #758

benlesh · 2015-12-08T00:35:38Z

Merged with ef83066... thank you for the review @kwonoj

lock · 2018-06-07T02:41:51Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

benlesh mentioned this pull request Dec 1, 2015

Unsubscribed Subjects should throw ObjectDisposedError if next, error or complete is called. #859

Closed

kwonoj reviewed Dec 2, 2015
View reviewed changes

benlesh added 4 commits December 7, 2015 14:20

feat(ObjectUnsubscribedError): add ObjectUnsubscribed error class

c44225f

this class was added to support throwing errors when members of Subjects were accessed in invalid ways after the Subject has been unsubscribed related #859 related #758

feat(BehaviorSubject): now throws when getValue is called after unsub…

76e0789

…scription related #758

refactor(Rx): re-add nextTick

0178992

benlesh closed this Dec 8, 2015

benlesh deleted the getValue branch April 27, 2016 17:19

lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(BehaviorSubject): add getValue method to access value #853

feat(BehaviorSubject): add getValue method to access value #853

benlesh commented Dec 1, 2015

kwonoj Dec 2, 2015

kwonoj commented Dec 2, 2015

benlesh commented Dec 8, 2015

lock bot commented Jun 7, 2018

feat(BehaviorSubject): add getValue method to access value #853

feat(BehaviorSubject): add getValue method to access value #853

Conversation

benlesh commented Dec 1, 2015

kwonoj Dec 2, 2015

Choose a reason for hiding this comment

kwonoj commented Dec 2, 2015

benlesh commented Dec 8, 2015

lock bot commented Jun 7, 2018