Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(finally): add test for the use of thisArg argument #789

Closed
wants to merge 1 commit into from

Conversation

staltz
Copy link
Member

@staltz staltz commented Nov 25, 2015

No description provided.

@kwonoj
Copy link
Member

kwonoj commented Nov 26, 2015

Maybe it's good time to discuss about make decision around drop thisArg? #744 is blocked for similar reason currently.

@staltz
Copy link
Member Author

staltz commented Nov 26, 2015

I'd be fine with dropping thisArg everywhere and also this PR. This PR was just a product of my effort to review each and every operator, if its tests are complete.

@kwonoj
Copy link
Member

kwonoj commented Dec 3, 2015

@staltz , I think this also can closed by #878 now leaving away from thisArg.

@staltz
Copy link
Member Author

staltz commented Dec 3, 2015

I'm fine with closing.

@staltz staltz closed this Dec 3, 2015
@staltz staltz deleted the tests-finally branch December 3, 2015 21:41
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants