Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fromEvent): passing a generic parameter is no longer deprecated #7406

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Dec 19, 2023

This should never have been deprecated. There's not really a great way to infer these types because it's for both DOM and Node APIs. So fromEvent<MouseEvent>(button, 'click') is totally a thing.

@benlesh benlesh merged commit 8f2caf1 into ReactiveX:master Dec 19, 2023
3 checks passed
@benlesh benlesh deleted the fix-fromEvent-deprecation branch December 19, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants