Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pairwise): make it recursion-proof #4743

Merged
merged 1 commit into from
May 9, 2019
Merged

fix(pairwise): make it recursion-proof #4743

merged 1 commit into from
May 9, 2019

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Apr 26, 2019

Description: pairwise calls next before saving the current value as the previous one, which makes it not recursively re-enterable. If its subscriber synchronously triggers the input observable, pairwise erroneously emits a pair with the wrong previous value.

Related issue: reduxjs/redux#3404

@coveralls
Copy link

coveralls commented Apr 27, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 8430

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 96.678%
Files with Coverage Reduction New Missed Lines %
src/internal/OuterSubscriber.ts 1 50.0%
Totals Coverage Status
Change from base Build 8414: -0.2%
Covered Lines: 5210
Relevant Lines: 5389
💛 - Coveralls

@thorn0 thorn0 changed the title fix(pairwise): make it recursion-pron fix(pairwise): make it recursion-proof Apr 27, 2019
cartant
cartant approved these changes Apr 27, 2019
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit 21ab261 into ReactiveX:master May 9, 2019
BioPhoton pushed a commit to BioPhoton/rxjs that referenced this pull request May 15, 2019
@thorn0 @BioPhoton
fix(pairwise): make it recursion-proof (ReactiveX#4743)
7815588
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thorn0 @coveralls @cartant @benlesh