fix(TestScheduler): stop sorting actual results #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to merge this one right away, since it fixes critical bugs with the test scheduler. |
- fixes an issue where actual results were being sorted when they should not have been - ensures rescheduled Actions will be added to subscription and torn down when appropriate - uses state to convey notification information to action work function rather than closure closes #422
| var c = cold( '----c---c---c---c---(c|)'); | ||
| var d = cold( '----(d|)' ); | ||
| var e1 = hot('a---b-----------c-------d-------|' ); | ||
| var expected = '----a---(ab)(ab)(ab)c---c---(cd)c---(c|)'; |
There was a problem hiding this comment.
It finally looks like it should. (ab) 👍
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #422