docs(skipUntil): add description and example with an interval waiting for click #4696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngfelixl
changed the title
Pull Request Test Coverage Report for Build 8444
💛 - Coveralls |
niklas-wortmann
requested changes
May 1, 2019
src/internal/operators/skipUntil.ts
Outdated
| @@ -10,8 +10,35 @@ import { Subscription } from '../Subscription'; | |||
| /** | |||
| * Returns an Observable that skips items emitted by the source Observable until a second Observable emits an item. | |||
| * | |||
| * The `skipUntil` operator causes the observable stream to skip the emission of values until the passed in observable returns the first value. | |||
There was a problem hiding this comment.
observable returns the first value. I think it would be clearer if it says observable emits the first value
There was a problem hiding this comment.
Thanks @jwo719. I've implemented your requested change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The example contains two base observables. An interval and a click listener. The resulting observable is the interval but skipping all the values, until the click event is fired.
Related issue (if exists):
#4631