Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(subscribe): don't swallow internal errors #4089

Merged
merged 22 commits into from
Sep 12, 2018
Merged

fix(subscribe): don't swallow internal errors #4089

merged 22 commits into from
Sep 12, 2018

Commits on Sep 7, 2018

  1. chore(reportError): implement reportError

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    9a309c0 View commit details
    Browse the repository at this point in the history

  2. fix(subscribe): don't swallow internal errors 

    Closes ReactiveX#3803
    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    ff3f06e View commit details
    Browse the repository at this point in the history

  3. chore(reportError): remove console.log from test

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    6801bbd View commit details
    Browse the repository at this point in the history

  4. chore(reportError): test destination is Subscriber

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    506eb42 View commit details
    Browse the repository at this point in the history

  5. test(reportError): use closed observer

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    ec98f5b View commit details
    Browse the repository at this point in the history

  6. chore(reportError): test subscriber symbol too

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    936b26b View commit details
    Browse the repository at this point in the history

  7. chore(reportError): fix logic

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    1ed1339 View commit details
    Browse the repository at this point in the history

  8. chore(reportError): rename to consoleWarn

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    e4959af View commit details
    Browse the repository at this point in the history

  9. test(reportError): stub the console

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    669ee9c View commit details
    Browse the repository at this point in the history

  10. chore(reportError): fix whitespace

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    3ee03c0 View commit details
    Browse the repository at this point in the history

  11. refactor(reportError): use canReportError instead

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    9d8cb76 View commit details
    Browse the repository at this point in the history

  12. refactor(canReport): remove recursion

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    bc8f54c View commit details
    Browse the repository at this point in the history

  13. test(subscribe): test internal error reporting

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    1a9d49a View commit details
    Browse the repository at this point in the history

  14. test(bindCallback): test error reporting

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    bbfaed0 View commit details
    Browse the repository at this point in the history

  15. test(bindNodeCallback): test error reporting

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    1fd1807 View commit details
    Browse the repository at this point in the history

  16. chore(canReport): fix JSDoc

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    6f40412 View commit details
    Browse the repository at this point in the history

  17. chore(test): fix test description

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    daa02c4 View commit details
    Browse the repository at this point in the history

  18. test(canReport): use noop error handlers

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    ed2a617 View commit details
    Browse the repository at this point in the history

  19. chore(canReport): use isTrustedSubscriber

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    1b53211 View commit details
    Browse the repository at this point in the history

  20. chore(canReport): restrict observer type

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    30440d2 View commit details
    Browse the repository at this point in the history

  21. chore(canReport): fix tests

    @cartant
    cartant committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    d640e9d View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2018

  1. chore(canReport): use console.warn directly

    @cartant
    cartant committed Sep 8, 2018
    Configuration menu
    Copy the full SHA
    14a6c61 View commit details
    Browse the repository at this point in the history