feat(zip): zip now supports never-ending iterables #399
Conversation
|
The controversial thing here is that it reduces performance slightly from what is in master... from 98,000 ops/sec Still substantially faster than the older versions of RxJS. However... this does include fixes to how the returned observable completes. It's hard to compare apples to apples until those fixes are in what's in master. So that will be next. |
|
With (one possible set of) fixes to So really the comparison for this feature is likely: 89,000 vs 78,000 ops/sec. The upside is it enables zipping with an "infinite" resource without locking a thread or creating a huge buffer. |
|
@steveorsomethin ... since you're more in-tune with TVUI/Netflix perf needs for these operators, do you view the perf differences mentioned above as okay vs the value of this PR? One reason I feel like this is okay is it makes zip slightly less dangerous. |
- adds support for never-ending iterables - adds fast-track for arrays - adds additional tests for zip - fixes issues where completion does not happen at the appropriate moment closes #397
|
Per a conversation with @steveorsomethin and @ktrott: The small change in performance isn't enough to outway the benefit of the new functionality and shouldn't effect anything in the lower-end hardware or non-JIT'ed runtimes Netflix needs to support. Merged. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes #397