Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publishReplay): type inference improved #3437

Merged
merged 1 commit into from
Mar 15, 2018
Merged

fix(publishReplay): type inference improved #3437

merged 1 commit into from
Mar 15, 2018

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Mar 15, 2018

closes #3260

@benlesh benlesh requested a review from kwonoj March 15, 2018 20:59
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.544% when pulling 696d04e on benlesh:fix-publishReplay-typings into c611403 on ReactiveX:master.

@benlesh benlesh merged commit dd7c9f1 into ReactiveX:master Mar 15, 2018
This was referenced Mar 19, 2018
Closed
Closed
@ivan7237d
Copy link

@benlesh shouldn't publishReplay return a ConnectableObservable? In my code I call publishReplay then connect, and now I have to manually cast the retval of publishReplay...

@lock lock bot locked as resolved and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kwonoj kwonoj Awaiting requested review from kwonoj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipe operator publishReplay cannot infer generic type.
3 participants
@benlesh @coveralls @ivan7237d