Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TestScheduler): Add subscription schedule to expectObservable #3429

Closed
wants to merge 1 commit into from
Closed

Conversation

gstamac
Copy link
Contributor

@gstamac gstamac commented Mar 13, 2018

Description:

Related issue (if exists):

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0007%) to 97.545% when pulling 02f185e on gstamac:master into 556c904 on ReactiveX:master.

@kwonoj
Copy link
Member

kwonoj commented Mar 13, 2018

Appreciate for sending out PR! Unfortunately, we are currently in discussions of revising interface around test scheduler
(https://github.com/ReactiveX/rxjs-core-notes/blob/master/rxjs/2018/2018-02/february-28.md#discussed / #3231) and holding off updating existing interfaces meanwhile and let new interface exists in parallel for migration purpose. Please feel freely check out issues with related projects and share opinions if needed.

@kwonoj kwonoj closed this Mar 13, 2018
@gstamac
Copy link
Contributor Author

gstamac commented Mar 30, 2018

Please reconsider adding this PR. It is a minor contribution which doesn't change any API. It just implements something that should be there already. I really need this and it's really annoying to modify rxjs with every update.

@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants