fix(subscribeOn): remove subscribeOn from reexport to support treesha… #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
-+32.9KB-red.svg?style=flat-square){kind=icon}
-+2.1KB-red.svg?style=flat-square){kind=icon}
|
This look good... I think removing this ahead of a 5.5 release is better than including it and having it cause hard to explain bundle size problems for people. Especially given our top priority is decreasing deployment size for people. We can always readd it later and not break semver. |
|
ping @kwonoj for second opinion. |
benlesh
requested changes
Oct 4, 2017
Simply adding a link to the issue tracking the reason subscribeOn was omitted.
benlesh
approved these changes
Oct 4, 2017
kwonoj
approved these changes
Oct 4, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kability
There is more research to be done (see #2900), but right now
subscribeOnneeds to be removed fromoperators/index.ts. Having it in there pulls in a tree totaling around 20k unminified. The tree that gets pulled in includes subscribeOn, schedulers/asap, AsapAction, ImmediateDefiniton, root, and a bit more.