Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(withLatestFrom): change from hot to cold observable in marble test #2578

Merged
merged 1 commit into from
Apr 30, 2017
Merged

fix(withLatestFrom): change from hot to cold observable in marble test #2578

merged 1 commit into from
Apr 30, 2017

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Apr 25, 2017

fixes #2526

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.644% when pulling 0c65446 on Boshen:withLatestFrom-spec-cold-observable into e69d876 on ReactiveX:master.

@staltz
Copy link
Member

staltz commented Apr 25, 2017

LGTM

@kwonoj kwonoj merged commit a8d74d3 into ReactiveX:master Apr 30, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo/error in withLatestFrom() test?
4 participants
@Boshen @coveralls @staltz @kwonoj