Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Subscription): fold ChildSubscription logic into Subscriber to prevent operators from leaking ChildSubscriptions. #2360

Merged
merged 1 commit into from
Feb 13, 2017
Merged

fix(Subscription): fold ChildSubscription logic into Subscriber to prevent operators from leaking ChildSubscriptions. #2360

merged 1 commit into from
Feb 13, 2017

Commits on Feb 13, 2017

  1. fix(Subscription): fold ChildSubscription logic into Subscriber to pr… 

    …event operators from leaking ChildSubscriptions.

The addition of ChildSubscription to fix ReactiveX#2244 accidentally introduced a different memory leak. Most operators that add and remove inner Subscriptions store the inner Subscriber instance, not the value returned by Subscription#add. When they try to remove the inner Subscription manually, nothing is removed, because the ChildSubscription wrapper instance is the one added to the subscriptions list.

Fixes ReactiveX#2355
    @trxcllnt
    trxcllnt committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    9567ca0 View commit details
    Browse the repository at this point in the history