chore(package.json): trigger lint against staged files only #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @Blesh suffered by slow lint. While this isn't definite answer to lint speed itself, this can be short-term workaround. |
|
LGTM |
|
above comment was trying to see if I can pass LGTM checker. Seems not. |
Merged
|
LGTM |
|
I think LGTM.co needs at least two confirmations. |
Make sense, let me try later. |
|
LGTM |
|
LGTM |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces module
lint-stagedvia wiring existing git hooks to pre-commit. Since checked in codebase is already guarded by full lint, it doesn't necessarily required to trigger full lint each time per check in. This PR makes automatically trigger lint only against staged files, reduced daily-flow time consumption on lint.commit, lint will be triggered automatically only for staged files. Failure will block commit.linttasks remain, allows manual full lint if possible.lint_stagedtask will allow trigger lint manually against staged files, do not need try commit each time for trigger lint.traviswill run full lint per each build to serve as guard.NOTE : I think #1731 is still valid when codebase grown, need frequent full lint including CI servers.
Related issue (if exists):
relates to #1731.