Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typings): update type definition for finally #1673

Merged
merged 1 commit into from
Apr 29, 2016

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Apr 29, 2016

Description:

This PR updates interface definition for finally to properly pass source observable's type.

Related issue (if exists):

  • pass type of source observable

closes #1672

@kwonoj
Copy link
Member Author

kwonoj commented Apr 29, 2016

/cc @david-driscoll @johnpapa

@kwonoj kwonoj merged commit 3ace1af into ReactiveX:master Apr 29, 2016
@kwonoj kwonoj deleted the type-finally branch April 29, 2016 22:48
@kwonoj
Copy link
Member Author

kwonoj commented Apr 29, 2016

Merged with 3ace1af.

@david-driscoll
Copy link
Member

👍

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

finally is not passing observable through properly
2 participants