docs(CONTRIBUTING): add GitHub Issue and PR template #1432
Conversation
| @@ -0,0 +1,21 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
is this comment appears up in template? view markdown in PR shows only non commented parts.
There was a problem hiding this comment.
Yup it appears. I saw it in Typescript repo's issue template.
|
I prefer not use the Issue and PR template, look at the angular2's new issures, it's annoying and not provide clearer intents. |
|
I'm still in favor of (at least trying) template to see if this can help anyone who want to contribute can leverage it. After rolling this out and notice if this confuses people, can be easily taken out. |
|
|
||
| Before you continue, consider the following: | ||
|
|
||
| If you have a "How do I do ...?" question, it is better for you and for us that this question is placed in [StackOverflow](http://stackoverflow.com/questions/tagged/rxjs) or some chat channel. This way, you are making it easier for others to learn from your experiences too. |
There was a problem hiding this comment.
I think StackOverflow actually has an rxjs5 tag.
There was a problem hiding this comment.
I'd like to reword this section, honestly. (Sorry, haha)
QUESTIONS: Please direct questions to [StackOverflow](http://stackoverflow.com/questions/tagged/rxjs), our maintainers and the larger community actively answer questions there, and it's a much better format for Q&A. It's also more likely to help others with similar questions.
staltz
force-pushed
the
operator-contribution-guideline
branch
from
0214964
to
2fbac1d
Compare
|
@kwonoj can you help explain what a Type Definition test is and where to find a good example? |
|
PS @Blesh I updated the PR |
Also about checklist to include new operators Fixes issues ReactiveX#1355 and ReactiveX#1429
staltz
force-pushed
the
operator-contribution-guideline
branch
from
2fbac1d
to
9fbfb5b
Compare
|
Change looks good to me, explanation regarding type definition test can be added later in detail once PR's checked in. |
Yeah you can do that since you understand better about those tests. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Also about checklist to include new operators
Fixes issues #1355 and #1429