-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate test cases into typescript #1364
Conversation
7004c10
to
b101fc4
Compare
wow! 👏 |
|
@kwonoj holy wow! 👏 🎩 I like that code coverage increased too. 👍 |
b101fc4
to
3f18563
Compare
3f18563
to
ca5f0a7
Compare
This is nuts. In a good way. I'm super pleased with this PR. Looks good to me so far. Question: When you were doing this, did you |
: actually I didn't, some of files were auto recognized by git as renamed and some weren't. :( Shall I apply it and update PR accordingly? |
@kwonoj: Looks good to me other than some of the other npm scripts now seem "dead". |
- migrate helper to typescript, primitive port focus on build pass without regression
ca5f0a7
to
60631e0
Compare
: I've completely missed those, my bad. Instead of removing it, amended those script to include test case build also. I'll think about fine grained script control in further. (such as combination of build src / test, + run test + coverage...) |
Okay... LGTM |
Merged with 4bc32b7. Now one step closer to more type-friendly codebase :) I'll work on followup changes to update type definitions as well. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes #661.
This PR aims to use existing unit test environment for type definition validation as well by migrating into typescript based. As in first step of incremental changes, this specific PR targets migrating test cases only without adding any other changes such as adding type validation tests, fix type definition in code bases, etcs.
To avoid test cases are breaking while migration this PR includes huge chunk of file changes, but most of them are simply amending existing test cases into typescript friendly. High level changes are as below.
test_buildonly
: this will compile test only without executing it for cases like type validation test running.test_nobuild
: in opposite to above command, this'll execute existing compiled test without rebuild, reduces test turnaround time when test cases are infrequently changestest
will executetest_buildonly && test_nobuild
Further goals
Opinion, suggestions are gladly welcome.
/cc @david-driscoll , @robwormald for visibility.