generated typings for bindCallback.create #1087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @robwormald @jeffbcross @kwonoj ... also @david-driscoll you'll probably want to rebase both of these. |
david-driscoll
force-pushed
the
typings-option-b
branch
from
c7ebda0
to
64ff686
Compare
|
@Blesh rebased. |
david-driscoll
force-pushed
the
typings-option-b
branch
from
64ff686
to
0e8204c
Compare
|
Apologizes for making this PR long-hanging. I'll start look into this and will provide some inputs if I have :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing against manual maintenance of types to spur on discussion of the best approach. I picked a single file here just as an example case. See #1086
As a reference for TypeScript itself, these typings can't be simplified much more without losing the enhanced experience of operating against them.
microsoft/TypeScript#5453 may be the answer, not sure if it answers all the possible use cases. It is currently on the road map for 2.0.
I realize there will be tons of opinions my only goal is to make the TypeScript experience with RxJS5 as good as we have gotten the experience in RxJS4.