Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to ScalarObservable-spec to cover thisArgs for filter, map, reduce, etc. #996

Closed
benlesh opened this issue Dec 8, 2015 · 2 comments
Closed

Add tests to ScalarObservable-spec to cover thisArgs for filter, map, reduce, etc. #996

benlesh opened this issue Dec 8, 2015 · 2 comments
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@benlesh
Copy link
Member

benlesh commented Dec 8, 2015

Just what it says. We're missing some tests there.
@benlesh benlesh added the help wanted Issues we wouldn't mind assistance with. label Dec 8, 2015
@luisgabriel
Copy link
Contributor

I can work on this one.

luisgabriel added a commit to luisgabriel/RxJS that referenced this issue Dec 8, 2015
@luisgabriel
feat(reduce): add thisArg parameter
ef890a8 
Adds thisArg as third argument to have symmetry with native Array.prototype.reduce().

Relates to ReactiveX#878 and ReactiveX#996.
@luisgabriel luisgabriel mentioned this issue Dec 8, 2015
Closed
luisgabriel added a commit to luisgabriel/RxJS that referenced this issue Dec 10, 2015
@luisgabriel
test(ScalarObservable): add test cases for thisArg
4141a77 
Closes ReactiveX#996.
@luisgabriel luisgabriel mentioned this issue Dec 10, 2015
Closed
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luisgabriel @benlesh