-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update static operators to accept promises across the board #1483
Comments
Is this related to #1246? |
@kwonoj yes it is |
Really, there shouldn't be anything public facing that "accepts" |
We should probably make separate issues for the operators in question. |
Can I remind people that if future PRs change the signature of an operator, please remember to update also the docs that I wrote for them. Otherwise docs will be a moving target |
I think this one's covered mostly, can this be closed maybe? (Assume |
I think most static operators are now covered as commented, /cc @Blesh for visibility before closing this out and switching to open issues for each individuals, in case I miss something should be covered before closing. |
Closing this, if there's remaining operator will file separate. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
A lot of this is my fault, but given that we've decided to interop with promises in most places, we should probably ensure we do it consistently. That means updating the family of static
defer
creation operators (defer, if, using, etc.) to accept promises, lowercase-o observables, etc. to use our internalsubscribeToResult
function.The text was updated successfully, but these errors were encountered: