fix(shareReplay): handle possible memory leaks

ReactiveX · Dec 14, 2020 · 3e64f6b · 3e64f6b
1 parent 1e1e022
commit 3e64f6b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/internal/operators/shareReplay.ts b/src/internal/operators/shareReplay.ts
@@ -108,13 +108,17 @@ function shareReplayOperator<T>({
           subject.complete();
         },
       });
+      if (isComplete) {
+        subscription = undefined;
+      }
     } else {
       innerSub = subject.subscribe(this);
     }
 
     this.add(() => {
       refCount--;
       innerSub.unsubscribe();
+      innerSub = undefined;
       if (subscription && !isComplete && useRefCount && refCount === 0) {
         subscription.unsubscribe();
         subscription = undefined;