Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

feat(operators): Add signature based on parameters collection #284

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

DiedrikDM
Copy link
Contributor

Resolve signature from name, parameters and return type values as per #168.
This change includes an update to the OperatorDoc type, because the return type of every operator needed to be included.
All existing operators have been updated as well to include the correct return type.
Some updates to the css were required to add colors to the signature.
Added a new pipe (ArgumentPipe) to create a nice tooltip when hovering over the arguments.

Resolve signature from name, parameters and return type values as per ReactiveX#168. This change includes an
update to the OperatorDoc type, because the return type of every operator needed to be included. All
existing operators have been updated as well to include the correct return type. Some updates to the
css were required to add colors to the signature. Added a new pipe (ArgumentPipe) to create a nice
tooltip when hovering over the arguments.
@codecov-io
Copy link

codecov-io commented Feb 27, 2018

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         116      116           
  Lines         445      445           
  Branches        9        9           
=======================================
  Hits          404      404           
  Misses         40       40           
  Partials        1        1
Impacted Files Coverage Δ
src/operator-docs/combination/mergeAll.ts 100% <ø> (ø) ⬆️
src/operator-docs/transformation/partition.ts 100% <ø> (ø) ⬆️
src/operator-docs/transformation/bufferCount.ts 100% <ø> (ø) ⬆️
src/operator-docs/combination/concatAll.ts 100% <ø> (ø) ⬆️
src/operator-docs/combination/startWith.ts 100% <ø> (ø) ⬆️
src/operator-docs/filtering/take.ts 100% <ø> (ø) ⬆️
src/operator-docs/filtering/debounce.ts 100% <ø> (ø) ⬆️
src/operator-docs/transformation/window.ts 100% <ø> (ø) ⬆️
src/operator-docs/transformation/switchMap.ts 100% <ø> (ø) ⬆️
src/operator-docs/combination/withLatestFrom.ts 100% <ø> (ø) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937bc7d...f729c8b. Read the comment docs.

@niklas-wortmann
Copy link
Member

First of all thanks for this much work! I will take a look at this pr and give some feedback.

@DiedrikDM
Copy link
Contributor Author

@jwo719 I'm also pretty sure that a more UX proficient person (than me) should look at it. I made a couple of choices right now in the implementation, like colors and a tooltip that maybe could/should be done in an other way...

@ashwin-sureshkumar
Copy link
Collaborator

@DiedrikDM - please resolve conflicts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants