docs(operators): add documentation for mergeMap #201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
=======================================
Coverage 77.14% 77.14%
=======================================
Files 15 15
Lines 175 175
Branches 7 7
=======================================
Hits 135 135
Misses 40 40Continue to review full report at Codecov.
|
| 'operatorType': 'transformation' | ||
| name: 'mergeMap', | ||
| operatorType: 'transformation', | ||
| signature: `public mergeMap(project: function(value: T, ?index: number): ObservableInput, |
There was a problem hiding this comment.
Think index may be messed up here ?index: number.
There was a problem hiding this comment.
@btroncone I didn't get it.
There was a problem hiding this comment.
@sumitarora I just meant the signature looks off mergeMap(project: function(value: T, ?index: number), should the ? be there?
| { | ||
| type: 'Tip', | ||
| text: | ||
| 'Maps each value to an Observable, then flattens all of these inner Observables using mergeAll.' |
There was a problem hiding this comment.
Can we add a link to mergeAll?
sumitarora
force-pushed
the
docs-mergeMap
branch
from
7fe3ef1
to
f89690d
Compare
Generated by 🚫 dangerJS |
|
@btroncone - Could you please re-review this one ? |
| name: | ||
| 'Map and flatten each letter to an Observable ticking every 1 second', | ||
| code: ` | ||
| const letters = Rx.Observable.of('a', 'b', 'c'); |
There was a problem hiding this comment.
Can you please update it to ES6 imports and pipeable operators?
| 'operatorType': 'transformation' | ||
| name: 'mergeMap', | ||
| operatorType: 'transformation', | ||
| signature: `public mergeMap(project: function(value: T, ?index: number): ObservableInput, |
There was a problem hiding this comment.
it should be index?: number if it is optional but as per source IDTS.
Closes: #119