docs(operators): add documentation for operator map #153
Conversation
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 7 7
Lines 78 78
Branches 5 5
=======================================
Hits 71 71
Misses 6 6
Partials 1 1Continue to review full report at Codecov.
|
|
@natmegs 👍 |
| `, | ||
| externalLink: { | ||
| platform: 'JSBin', | ||
| url: 'http://jsbin.com/geyokey/embed?js,console' |
There was a problem hiding this comment.
@natmegs I am seeing this error in JS Bin. Please import library in the bin and update link.
"ReferenceError: Rx is not defined
at geyokey.js:1:19
at https://static.jsbin.com/js/prod/runner-4.1.1.min.js:1:13850
at https://static.jsbin.com/js/prod/runner-4.1.1.min.js:1:10792"
There was a problem hiding this comment.
thx for helping review this @sumitarora (@natmegs super looking forward to your first PR in this repo!)
There was a problem hiding this comment.
Thanks for the feedback! I will fix the bin this evening :)
|
thx for helping review @sumitarora! @natmegs let us know how we can help you get to the finish line! |
|
@ladyleet I pushed a change for the JSbin last night! Is there anything left that I've forgotten? Thanks! |
|
@natmegs can you go ahead and rebase? @sumitarora anything else? |
|
@ladyleet @sumitarora Alright, I believe the branch is now up to date. If any other changes are needed I'll get them fixed up asap. Thanks for all the help with this one. The next one will be much smoother now! |
| 'operatorType': 'transformation' | ||
| name: 'map', | ||
| operatorType: 'transformation', | ||
| signature: 'public map(project: Function, thisArg: any): Observable', |
There was a problem hiding this comment.
You could mark optional parameters with question mark:
public map(project: Function, thisArg?: any)
There was a problem hiding this comment.
There is an issue to discuss this #168 so this PR should be good to go.
|
Woot thanks so much @natmegs for your contribution! :) |
Add initial version of documentation for creation operator 'empty'. WIP since JSbin is down and cannot test embedded link.
closes #117