Upgrade to RxJava 1.0.0-RC5 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jbripley
commented
Oct 3, 2014
jbripley
commented
- If RxJava is updated with the same signature changes with Change repeatWhen and retryWhen signatures. RxJava#1720, the conversion from RxScala to RxJava can be simplified, without any external signature changes in RxScala.
- If RxJava is updated with the same signature changes with ReactiveX/RxJava#1720, the conversion from RxScala to RxJava can be simplified, without any external signature changes in RxScala.
|
Nice, but let's wait with this until there's an RxJava release which contains ReactiveX/RxJava#1720. |
|
Are you ready to proceed with this now that 1.0.0-RC5 of RxJava is released with these changes? |
|
Yes, I'll push an update to this PR later today or tomorrow. |
|
Should I include the removal of groupByUntil in this PR as well, since I need to update to RxJava 1.0.0-RC5? |
|
Good point ... yes. But the name of the pull request should be changed then so it's clear for historical purposes that it was upgrading to 1.0.0-RC5 and all related changes. |
- Update retryWhen/repeatWhen RxJava signature conversion to match - Remove groupByUntil methods since they were removed from RxJava
jbripley
changed the title
|
LGTM |
|
Ship it. |
benjchristensen
added a commit
that referenced
this pull request
Oct 8, 2014
Upgrade to RxJava 1.0.0-RC5
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.