Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Bounded ObserveOn #888

Merged

Conversation

benjchristensen
Copy link
Member

Reverting to only having unbounded observeOn in public API as per comment at #835 (comment)

Leaving the bounded implementation as an internal operator implementation for now to be discussed further in v0.18 dev cycle.

@benjchristensen
Copy link
Member Author

While performance testing this it was found that NewThreadScheduler appears to be the source of performance degradation, not observeOn itself. Using ImmediateScheduler 0.16 and 0.17 were very similar. The code for observeOn in 0.17 is now basically the same as 0.16 except using lift and avoiding the use of materialize to reduce object creation.

@benjchristensen
Copy link
Member Author

Unit tests passing on local machine ... merging:

BUILD SUCCESSFUL

Total time: 1 mins 20.181 secs

benjchristensen added a commit that referenced this pull request Feb 17, 2014
@benjchristensen benjchristensen merged commit 18f545a into ReactiveX:master Feb 17, 2014
@benjchristensen benjchristensen deleted the observeOn-bounded-unbounded branch February 17, 2014 19:02
@cloudbees-pull-request-builder

RxJava-pull-requests #821 FAILURE
Looks like there's a problem with this pull request

jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants