Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Changes While Fixing GroupBy #847

Merged
merged 15 commits into from
Feb 11, 2014

Conversation

benjchristensen
Copy link
Member

No description provided.

- support synchronous unsubscribe now
- Splitting them allows clearer code and avoids use of queue for normal merge.
- used in MergeMaxConcurrent and ObserveOn
- allows for blocking onNext calls when full while still supporting unsubscribe.
Make this public so that operator chaining can use it.
Usage would be someObservable.nest().lift(f) for lifting a function that expects Observable<Observable<T>> such as `repeat`.
- There were bugs in the implementation, this fixes some of them. In particular, it was unsubscribing from the parent when all children were completed, and that would unsubscribe even if new groups were going to come.
- There are still problems related to `subscribeOn` and the "time gap" that are being played with. Unit tests related to that are still failing.
It had been changed to only support >0, put it back to >=0
The new OperatorMerge class still exists, but reverting this one.
I messed up the thread safety and don't have time to figure it out.
- stressing it further while hunting down non-determism
@cloudbees-pull-request-builder

RxJava-pull-requests #768 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request Feb 11, 2014
@benjchristensen benjchristensen merged commit 342d90c into ReactiveX:master Feb 11, 2014
@benjchristensen benjchristensen deleted the groupby-and-friends branch February 11, 2014 08:07
@benjchristensen benjchristensen restored the groupby-and-friends branch February 11, 2014 20:30
@benjchristensen benjchristensen deleted the groupby-and-friends branch February 11, 2014 20:44
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
…hen a BulkheadFullException occurs ReactiveX#847

The ThreadPoolBulkhead is does not return a CompletionStage when a task could not be submitted, because the Bulkhead is full. The ThreadPoolBulkhead throws a BulkheadFullException instead. Analog to the ThreadPoolExecutor which throws the RejectedExecutionException. The BulkheadFullException is not handled correctly by the BulkheadAspect.
The BulkheadAspect should convert the BulkheadFullException into a exceptionally completed future so that the FallbackDecorator works as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants